-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design System: Design tokens #2203
Commits on Nov 5, 2024
-
Do not modify Sample object when rendering ElementalCompositionCustom
Assigning to `el_composition.data` would cause the sample to be considered as `isEdited`.
Configuration menu - View commit details
-
Copy full SHA for 6fb49ef - Browse repository at this point
Copy the full SHA 6fb49efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b8f318 - Browse repository at this point
Copy the full SHA 3b8f318View commit details -
Do not update state during render in InboxModal
Before this change, we would `this.state.sortColumn = ...` during render in order to get the latest value from UserStore. Now we properly listen (and unlisten) for store changes and update the state using `this.setState`. With this change we also set the initial UIStore state when the component mounts and not only when the store state changes.
Configuration menu - View commit details
-
Copy full SHA for bc81f62 - Browse repository at this point
Copy the full SHA bc81f62View commit details -
Remove unused genericEls prop from ManagingActions
The ManagingActions component handles syncing genericEls with UserStore itself. No need to pass that information in as prop.
Configuration menu - View commit details
-
Copy full SHA for 17527ba - Browse repository at this point
Copy the full SHA 17527baView commit details -
Do not copy UIStore state into local component state
We used to copy the state to determine whether the selection had changed or not. However, we can simply calculate that information from the UIStore state without the local state.
Configuration menu - View commit details
-
Copy full SHA for 3431623 - Browse repository at this point
Copy the full SHA 3431623View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b6191 - Browse repository at this point
Copy the full SHA 39b6191View commit details -
Remove unnecessary UIAction.selectSyncCollection
This used to trigger `UIState.handleSelectSyncCollection` which forwarded to `UIStore.handleSelectCollection`. Removing in favour of less indirection.
Configuration menu - View commit details
-
Copy full SHA for 8f16025 - Browse repository at this point
Copy the full SHA 8f16025View commit details -
Use currentTab data stored in UserStore
Before this change, we would always reset the currentTab to 0 and not use the data stored in the UserStore. This was fine when we never unmounted/mounted the ElementList component but leads to the undesired effect of not respecting the user's selected tab when we unmount/mount the component.
Configuration menu - View commit details
-
Copy full SHA for b53063a - Browse repository at this point
Copy the full SHA b53063aView commit details -
Remove obsolete
update
prop in ResearchPlanDetailsThis was used to force a re-render when changing to full screen. It does not seem to be necessary anymore.
Configuration menu - View commit details
-
Copy full SHA for 7e02ed6 - Browse repository at this point
Copy the full SHA 7e02ed6View commit details -
Prefer setState over modifying state directly
Also fix collection type. JS Array has no `size` property.
Configuration menu - View commit details
-
Copy full SHA for ddec9b3 - Browse repository at this point
Copy the full SHA ddec9b3View commit details
Commits on Nov 6, 2024
-
Narrow and define ElementAllCheckbox props API
Instead of passing a complex `ui` prop with undefined keys, we now pass only what is necessary to the component. This shows that the formerly used prop `checked` was not provided.
Configuration menu - View commit details
-
Copy full SHA for 436d41f - Browse repository at this point
Copy the full SHA 436d41fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 045484b - Browse repository at this point
Copy the full SHA 045484bView commit details -
Fix Inbox size dropdown with size small
The `.small-panel` class adds `overflow: hidden`, hiding the dropdown.
Configuration menu - View commit details
-
Copy full SHA for aa65e5e - Browse repository at this point
Copy the full SHA aa65e5eView commit details -
Disable rather than hide prev/next buttons in element pagination
This way the buttons jump around less.
Configuration menu - View commit details
-
Copy full SHA for 82f79f0 - Browse repository at this point
Copy the full SHA 82f79f0View commit details -
Separate Home and mydb Navigation components
With the new layout, the two components will look and function differently.
Configuration menu - View commit details
-
Copy full SHA for 40de134 - Browse repository at this point
Copy the full SHA 40de134View commit details -
Configuration menu - View commit details
-
Copy full SHA for 273bcbd - Browse repository at this point
Copy the full SHA 273bcbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b3ee2a - Browse repository at this point
Copy the full SHA 3b3ee2aView commit details -
Fix selecting items from sample import
While selecting/deselecting would work in production, there were plenty of errors in the console because the SelectCellRenderer's rowIndex was not used/passed correctly. Probably because of a API change in AgGridReact.
Configuration menu - View commit details
-
Copy full SHA for 4f365f8 - Browse repository at this point
Copy the full SHA 4f365f8View commit details -
Use ElementStore for managing sdf upload confirmation preview
...instead of the global NavigationModal
Configuration menu - View commit details
-
Copy full SHA for a86e9cf - Browse repository at this point
Copy the full SHA a86e9cfView commit details -
Remove NavigationModal and corresponding UI state
The previous commits make this component obsolete.
Configuration menu - View commit details
-
Copy full SHA for 3a40e84 - Browse repository at this point
Copy the full SHA 3a40e84View commit details -
Configuration menu - View commit details
-
Copy full SHA for da655b1 - Browse repository at this point
Copy the full SHA da655b1View commit details -
Remove use of
user.profile.data.customClass
There does not seem to be a way to modify this value and there is no personally customizable theming in the new design.
Configuration menu - View commit details
-
Copy full SHA for e808ddb - Browse repository at this point
Copy the full SHA e808ddbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c4e429 - Browse repository at this point
Copy the full SHA 4c4e429View commit details -
Configuration menu - View commit details
-
Copy full SHA for 297a941 - Browse repository at this point
Copy the full SHA 297a941View commit details -
This patch introduces the app layout structure proposed by Shapefield' redesign document.
Configuration menu - View commit details
-
Copy full SHA for a840b04 - Browse repository at this point
Copy the full SHA a840b04View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8151a1 - Browse repository at this point
Copy the full SHA e8151a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81a3b04 - Browse repository at this point
Copy the full SHA 81a3b04View commit details -
Configuration menu - View commit details
-
Copy full SHA for cedb708 - Browse repository at this point
Copy the full SHA cedb708View commit details -
Configuration menu - View commit details
-
Copy full SHA for 196eef5 - Browse repository at this point
Copy the full SHA 196eef5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8da7b56 - Browse repository at this point
Copy the full SHA 8da7b56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d862a9 - Browse repository at this point
Copy the full SHA 0d862a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 248066b - Browse repository at this point
Copy the full SHA 248066bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6d801e - Browse repository at this point
Copy the full SHA f6d801eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0258dc - Browse repository at this point
Copy the full SHA b0258dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9838c0 - Browse repository at this point
Copy the full SHA b9838c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2712146 - Browse repository at this point
Copy the full SHA 2712146View commit details -
Split ScanCodeButton and PrintCodeButton
...because scanning is a global action and printing depends on the currently selected samples.
Configuration menu - View commit details
-
Copy full SHA for e6a4e1e - Browse repository at this point
Copy the full SHA e6a4e1eView commit details -
Update CollectionTree to new layout
We now keep all collection group headers visible on screen by having the list of collections in a group scroll when it exceeds the limit of what can be displayed.
Configuration menu - View commit details
-
Copy full SHA for 887401f - Browse repository at this point
Copy the full SHA 887401fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcfde68 - Browse repository at this point
Copy the full SHA fcfde68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bc3e7a - Browse repository at this point
Copy the full SHA 9bc3e7aView commit details -
Reduce the number of re-renders of Elements
We don't use the currentElement prop in ElementDetails. This means that we don't need to store it in this component. Subsequently we can boil down the state to a single `showDetailView` boolean, making it easy to not re-render when nothing has changed.
Configuration menu - View commit details
-
Copy full SHA for 170e9e0 - Browse repository at this point
Copy the full SHA 170e9e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7699f51 - Browse repository at this point
Copy the full SHA 7699f51View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd8130e - Browse repository at this point
Copy the full SHA cd8130eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b70a8eb - Browse repository at this point
Copy the full SHA b70a8ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for bba7d0e - Browse repository at this point
Copy the full SHA bba7d0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f948b1 - Browse repository at this point
Copy the full SHA 9f948b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34756a1 - Browse repository at this point
Copy the full SHA 34756a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fabc1e - Browse repository at this point
Copy the full SHA 1fabc1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2498ce0 - Browse repository at this point
Copy the full SHA 2498ce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49cd84c - Browse repository at this point
Copy the full SHA 49cd84cView commit details
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1e69d14 - Browse repository at this point
Copy the full SHA 1e69d14View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3774e8 - Browse repository at this point
Copy the full SHA c3774e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 575bce8 - Browse repository at this point
Copy the full SHA 575bce8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 116768e - Browse repository at this point
Copy the full SHA 116768eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47ec1fc - Browse repository at this point
Copy the full SHA 47ec1fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa0f7bd - Browse repository at this point
Copy the full SHA aa0f7bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1ab7b0 - Browse repository at this point
Copy the full SHA c1ab7b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fac6f5a - Browse repository at this point
Copy the full SHA fac6f5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc1d607 - Browse repository at this point
Copy the full SHA dc1d607View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaba557 - Browse repository at this point
Copy the full SHA eaba557View commit details -
Configuration menu - View commit details
-
Copy full SHA for f29a0e7 - Browse repository at this point
Copy the full SHA f29a0e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5081dc - Browse repository at this point
Copy the full SHA d5081dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f1e0d8 - Browse repository at this point
Copy the full SHA 2f1e0d8View commit details -
Fix additional popover Header breaking rounded border
The first <Popover.Header> is not the first DOM node in the <Popover>. React bootstrap prepends another element for the arrow, so :first-child does not work here. I attempted to use `.popover > *:nth-child(n + 2 of .popover-header)` but I suppose our css preprocessor does not support the relatively new nth-of selector, because the selector is mangled in the compiled output. https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#the_of_selector_syntax
Configuration menu - View commit details
-
Copy full SHA for 396cee1 - Browse repository at this point
Copy the full SHA 396cee1View commit details -
Rework tab layout editing to proper drag and drop
This patch introduces the TabLayoutEditor component with a drag-and-drop interface for reordering and hiding/showing tabs. The component accepts an ItemComponent via the `getItemComponent` prop for rendering individual items. With this patch we no longer need to manage the synthetic 'hidden' Tab when no tabs are currently hidden. This is now the editor component's responsibility and using code does not have to manage that. This also removes the `DragDropItemTypes.LAYOUT` constant in favor of a unique scope for each instance of the editor, because drag-and-drop is only supposed to work within a specific visible/hidden list combination and not globally across editors. State changes are now propagated via the `onLayoutChange` callback and not by reaching into the state of the component.
Configuration menu - View commit details
-
Copy full SHA for af51db2 - Browse repository at this point
Copy the full SHA af51db2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98fb5ed - Browse repository at this point
Copy the full SHA 98fb5edView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9df356 - Browse repository at this point
Copy the full SHA b9df356View commit details -
Configuration menu - View commit details
-
Copy full SHA for e686f49 - Browse repository at this point
Copy the full SHA e686f49View commit details