Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design System: Design tokens #2203

Closed
wants to merge 68 commits into from
Closed

Commits on Nov 5, 2024

  1. Do not modify Sample object when rendering ElementalCompositionCustom

    Assigning to `el_composition.data` would cause the sample to be
    considered as `isEdited`.
    maiwald committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6fb49ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b8f318 View commit details
    Browse the repository at this point in the history
  3. Do not update state during render in InboxModal

    Before this change, we would `this.state.sortColumn = ...` during render
    in order to get the latest value from UserStore. Now we properly listen
    (and unlisten) for store changes and update the state using
    `this.setState`.
    
    With this change we also set the initial UIStore state when the
    component mounts and not only when the store state changes.
    maiwald committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bc81f62 View commit details
    Browse the repository at this point in the history
  4. Remove unused genericEls prop from ManagingActions

    The ManagingActions component handles syncing genericEls with UserStore
    itself. No need to pass that information in as prop.
    maiwald committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    17527ba View commit details
    Browse the repository at this point in the history
  5. Do not copy UIStore state into local component state

    We used to copy the state to determine whether the selection had changed
    or not. However, we can simply calculate that information from the
    UIStore state without the local state.
    maiwald committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3431623 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    39b6191 View commit details
    Browse the repository at this point in the history
  7. Remove unnecessary UIAction.selectSyncCollection

    This used to trigger `UIState.handleSelectSyncCollection` which
    forwarded to `UIStore.handleSelectCollection`. Removing in favour of
    less indirection.
    maiwald committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8f16025 View commit details
    Browse the repository at this point in the history
  8. Use currentTab data stored in UserStore

    Before this change, we would always reset the currentTab to 0 and not
    use the data stored in the UserStore.
    
    This was fine when we never unmounted/mounted the ElementList component
    but leads to the undesired effect of not respecting the user's selected
    tab when we unmount/mount the component.
    maiwald committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b53063a View commit details
    Browse the repository at this point in the history
  9. Remove obsolete update prop in ResearchPlanDetails

    This was used to force a re-render when changing to full screen. It does
    not seem to be necessary anymore.
    maiwald committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7e02ed6 View commit details
    Browse the repository at this point in the history
  10. Prefer setState over modifying state directly

    Also fix collection type. JS Array has no `size` property.
    maiwald committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ddec9b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Narrow and define ElementAllCheckbox props API

    Instead of passing a complex `ui` prop with undefined keys, we now pass
    only what is necessary to the component.
    
    This shows that the formerly used prop `checked` was not provided.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    436d41f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    045484b View commit details
    Browse the repository at this point in the history
  3. Fix Inbox size dropdown with size small

    The `.small-panel` class adds `overflow: hidden`, hiding the dropdown.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    aa65e5e View commit details
    Browse the repository at this point in the history
  4. Disable rather than hide prev/next buttons in element pagination

    This way the buttons jump around less.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    82f79f0 View commit details
    Browse the repository at this point in the history
  5. Separate Home and mydb Navigation components

    With the new layout, the two components will look and function
    differently.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    40de134 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    273bcbd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3b3ee2a View commit details
    Browse the repository at this point in the history
  8. Fix selecting items from sample import

    While selecting/deselecting would work in production, there were plenty
    of errors in the console because the SelectCellRenderer's rowIndex was
    not used/passed correctly. Probably because of a API change in
    AgGridReact.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4f365f8 View commit details
    Browse the repository at this point in the history
  9. Use ElementStore for managing sdf upload confirmation preview

    ...instead of the global NavigationModal
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a86e9cf View commit details
    Browse the repository at this point in the history
  10. Remove NavigationModal and corresponding UI state

    The previous commits make this component obsolete.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3a40e84 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    da655b1 View commit details
    Browse the repository at this point in the history
  12. Remove use of user.profile.data.customClass

    There does not seem to be a way to modify this value and there is no
    personally customizable theming in the new design.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e808ddb View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4c4e429 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    297a941 View commit details
    Browse the repository at this point in the history
  15. Restructure App layout

    This patch introduces the app layout structure proposed by Shapefield'
    redesign document.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a840b04 View commit details
    Browse the repository at this point in the history
  16. Fix reaction SVG size

    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e8151a1 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    81a3b04 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    cedb708 View commit details
    Browse the repository at this point in the history
  19. Add basic Sidebar toggling

    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    196eef5 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    8da7b56 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    0d862a9 View commit details
    Browse the repository at this point in the history
  22. Add Support dropdown

    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    248066b View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    f6d801e View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    b0258dc View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    b9838c0 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    2712146 View commit details
    Browse the repository at this point in the history
  27. Split ScanCodeButton and PrintCodeButton

    ...because scanning is a global action and printing depends on the
    currently selected samples.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e6a4e1e View commit details
    Browse the repository at this point in the history
  28. Update CollectionTree to new layout

    We now keep all collection group headers visible on screen by having the
    list of collections in a group scroll when it exceeds the limit of what
    can be displayed.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    887401f View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    fcfde68 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    9bc3e7a View commit details
    Browse the repository at this point in the history
  31. Reduce the number of re-renders of Elements

    We don't use the currentElement prop in ElementDetails. This means that
    we don't need to store it in this component. Subsequently we can boil
    down the state to a single `showDetailView` boolean, making it easy to
    not re-render when nothing has changed.
    maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    170e9e0 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    7699f51 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    cd8130e View commit details
    Browse the repository at this point in the history
  34. improve styling for sidebar

    JoachimTillessen authored and maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b70a8eb View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    bba7d0e View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    9f948b1 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    34756a1 View commit details
    Browse the repository at this point in the history
  38. Fix spacing in collection tree

    JoachimTillessen authored and maiwald committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1fabc1e View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    2498ce0 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    49cd84c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Add styleguide stub

    maiwald committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1e69d14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3774e8 View commit details
    Browse the repository at this point in the history
  3. fix naming font files

    JoachimTillessen authored and maiwald committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    575bce8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    116768e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    47ec1fc View commit details
    Browse the repository at this point in the history
  6. Remove full screen mode

    maiwald committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    aa0f7bd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c1ab7b0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fac6f5a View commit details
    Browse the repository at this point in the history
  9. Style resize handle

    JoachimTillessen authored and maiwald committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dc1d607 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    eaba557 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f29a0e7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d5081dc View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2f1e0d8 View commit details
    Browse the repository at this point in the history
  14. Fix additional popover Header breaking rounded border

    The first <Popover.Header> is not the first DOM node in the <Popover>.
    React bootstrap prepends another element for the arrow, so :first-child
    does not work here.
    
    I attempted to use `.popover > *:nth-child(n + 2 of .popover-header)`
    but I suppose our css preprocessor does not support the relatively new
    nth-of selector, because the selector is mangled in the compiled output.
    
    https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#the_of_selector_syntax
    maiwald committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    396cee1 View commit details
    Browse the repository at this point in the history
  15. Rework tab layout editing to proper drag and drop

    This patch introduces the TabLayoutEditor component with a
    drag-and-drop interface for reordering and hiding/showing tabs.
    
    The component accepts an ItemComponent via the `getItemComponent` prop
    for rendering individual items.
    
    With this patch we no longer need to manage the synthetic 'hidden' Tab
    when no tabs are currently hidden. This is now the editor component's
    responsibility and using code does not have to manage that.
    
    This also removes the `DragDropItemTypes.LAYOUT` constant in favor of a
    unique scope for each instance of the editor, because drag-and-drop is
    only supposed to work within a specific visible/hidden list combination
    and not globally across editors.
    
    State changes are now propagated via the `onLayoutChange` callback and
    not by reaching into the state of the component.
    maiwald committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    af51db2 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    98fb5ed View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    b9df356 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e686f49 View commit details
    Browse the repository at this point in the history