[i18n] Impl i18n context menu translation #2394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarryCharon
requested review from
Yorha4D,
DorotaLuna,
shinshin86 and
a team
as code owners
huchenlei
requested changes
Feb 3, 2025
huchenlei
requested changes
Feb 3, 2025
src/scripts/app.ts
Outdated
| if (!values) return; | ||
| // Convert {w.name} to input | ||
| // Convert {w.name} to widget | ||
| var reInput = /Convert (.*) to input/; |
src/scripts/app.ts
Outdated
| var twgt = st("graphCanvasMenu. to widget", " to widget"); | ||
| for (var i = 0; i < values.length; i++) { | ||
| var value = values[i]; | ||
| // 这里对应 从 slot 拖拽弹出的菜单, 但翻译后 菜单不能正常工作 |
src/scripts/app.ts
Outdated
| function translateMenus(values, options) | ||
| { | ||
| if (!values) return; | ||
| // Convert {w.name} to input |
src/scripts/app.ts
Outdated
| const OriginalContextMenu = LiteGraph.ContextMenu; | ||
| LiteGraph.ContextMenu = function (values, options) { | ||
| if (options.hasOwnProperty("title")) { | ||
| options.title = st(`nodeDefs.${normalizeI18nKey(options.title)}.display_name`, options.title); |
There was a problem hiding this comment.
Before:
After:
I think this is an acceptable change. We can update the playwright test expectations.
There was a problem hiding this comment.
N.B. For some nodes, this will be a more significant change, as their type / display name differ more than just by spaces.
I use the context menu as a quick shorcut to find the actual node type ID - I have seen some Discord users talk about it also.
I think this is a good change though - we should surface the backend node type in some other way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has enhanced the right mouse click context menu translation.
┆Issue is synchronized with this Notion page by Unito