Use a WeakHashMap in WorldAttached to prevent memory leaks #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. |
|
It'll likely be relevant to all versions that uses the same implementation. I can target the default branch if you'd like. |
|
Yep, that would be nice |
|
As I can't retarget the branch from this PR, I've recreated this PR for the 1.18 branch at #4108. No changes from this commit aside from being rebased, still compiles and runs as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick backport of the WeakHashMap patch in Fabricators-of-Create#637 to fix Fabricators-of-Create#635, which maybe useful for if an event is somehow missed or is dealing with a misbehaving mod. I know that this version isn't subject to the same ClientLevel not being cleared bug, but I think this patch could be of value for preventing desync of branches and preventing future bugs.