Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a WeakHashMap in WorldAttached to prevent memory leaks #4065

Closed
wants to merge 1 commit into from
Closed

Use a WeakHashMap in WorldAttached to prevent memory leaks #4065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/com/simibubi/create/foundation/utility/WorldAttached.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

import java.lang.ref.WeakReference;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.WeakHashMap;
import java.util.function.BiConsumer;
import java.util.function.Consumer;
import java.util.function.Function;
Expand All @@ -22,7 +22,9 @@ public class WorldAttached<T> {

public WorldAttached(Function<LevelAccessor, T> factory) {
this.factory = factory;
attached = new HashMap<>();
// Weak key hashmaps prevent worlds not existing anywhere else from leaking memory.
// This is only a fallback in the event that unload events fail to fire for any reason.
attached = new WeakHashMap<>();
allMaps.add(new WeakReference<>(attached));
}

Expand Down