Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPDLP-3819] NPQ Post Separation Cleanup - Remove data in shared ECF statement tables for NPQ #5446

Merged
merged 4 commits into from
Jan 21, 2025
Merged

[CPDLP-3819] NPQ Post Separation Cleanup - Remove data in shared ECF statement tables for NPQ #5446

merged 4 commits into from
Jan 21, 2025

Conversation

mooktakim
Copy link
Contributor

Context

Changes proposed in this pull request

  • Delete NPQ records from:
    • Finance::StatementLineItem
    • Finance::Adjustment
    • Finance::Statement
    • ParticipantProfileSchedule
    • Finance::ScheduleMilestone
    • Finance::Milestone
    • Finance::Schedule
  • Updated spec and factories
  • Updated seed services and data

Guidance to review

@github-actions GitHub Actions
Copy link

Review app deployed to https://cpd-ecf-review-5446-web.test.teacherservices.cloud

@mooktakim mooktakim force-pushed the 3819-remove-data-in-shared-ecf-statement-tables-for-npq branch from 2c03c1b to f75d598 Compare January 17, 2025 10:49
leandroalemao
leandroalemao approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@leandroalemao leandroalemao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good tks 👍 😄

cwrw
cwrw approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@cwrw cwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thanks Mook!

@mooktakim mooktakim force-pushed the 3819-remove-data-in-shared-ecf-statement-tables-for-npq branch from f75d598 to 71ca374 Compare January 20, 2025 15:47
@mooktakim mooktakim added this pull request to the merge queue Jan 21, 2025
@mooktakim mooktakim removed this pull request from the merge queue due to a manual request Jan 21, 2025
@mooktakim mooktakim added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit cc71ab9 Jan 21, 2025
36 checks passed
@mooktakim mooktakim deleted the 3819-remove-data-in-shared-ecf-statement-tables-for-npq branch January 21, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroalemao leandroalemao leandroalemao approved these changes

@cwrw cwrw cwrw approved these changes

Assignees

@mooktakim mooktakim

@leandroalemao leandroalemao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mooktakim @cwrw @leandroalemao