Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDLP-3819] NPQ Post Separation Cleanup - Remove data in shared ECF statement tables for NPQ #5446

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/models/cpd_lead_provider.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ class CpdLeadProvider < ApplicationRecord
has_many :participant_declarations
has_many :statements, class_name: "Finance::Statement"
has_many :ecf_statements, class_name: "Finance::Statement::ECF"
has_many :npq_statements, class_name: "Finance::Statement::NPQ"

validates :name, presence: { message: "Enter a name" }
end
5 changes: 0 additions & 5 deletions app/models/finance/schedule.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,7 @@ class Schedule < ApplicationRecord

# cohort_start_year
delegate :start_year, to: :cohort, prefix: true

def npq?
false
end
end
end

require "finance/schedule/ecf"
require "finance/schedule/npq"
11 changes: 0 additions & 11 deletions app/models/finance/schedule/npq.rb

This file was deleted.

66 changes: 0 additions & 66 deletions app/models/finance/schedule/npq_ehco.rb

This file was deleted.

44 changes: 0 additions & 44 deletions app/models/finance/schedule/npq_leadership.rb

This file was deleted.

44 changes: 0 additions & 44 deletions app/models/finance/schedule/npq_specialist.rb

This file was deleted.

13 changes: 0 additions & 13 deletions app/models/finance/schedule/npq_support.rb

This file was deleted.

7 changes: 0 additions & 7 deletions app/models/finance/statement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ class Finance::Statement < ApplicationRecord
.where("deadline_date >= ?", Date.current)
}

STATEMENT_TYPES = %w[ecf npq].freeze

class << self
def current
with_future_deadline_date.order(deadline_date: :asc).first
Expand Down Expand Up @@ -84,10 +82,6 @@ def ecf?
false
end

def npq?
false
end

def payable?
false
end
Expand All @@ -102,4 +96,3 @@ def marked_as_paid?
end

require "finance/statement/ecf"
require "finance/statement/npq"
30 changes: 0 additions & 30 deletions app/models/finance/statement/npq.rb

This file was deleted.

11 changes: 0 additions & 11 deletions app/models/finance/statement/npq/paid.rb

This file was deleted.

11 changes: 0 additions & 11 deletions app/models/finance/statement/npq/payable.rb

This file was deleted.

Loading
Loading