Remove unused StreamBigQueryParticipantDeclarationsJob #5496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-5496-web.test.teacherservices.cloud |
ethax-ross
force-pushed
the
3986-remove-unused-bq-job
branch
from
0cd4c3f to
c657c5a
Compare
| @@ -4,6 +4,5 @@ | |||
| - priority_mailers | |||
| - mailers | |||
| - default | |||
| - big_query | |||
There was a problem hiding this comment.
Do we need to remove this queue via sidekiq web as well? Or just removing here will do the trick?
There was a problem hiding this comment.
I believe removing it here should be enough; we can check the UI afterwards though to make sure it all looks right 👍
leandroalemao
approved these changes
Jan 30, 2025
mooktakim
approved these changes
Jan 30, 2025
ethax-ross
force-pushed
the
3986-remove-unused-bq-job
branch
from
c657c5a to
411560c
Compare
Remove the `StreamBigQueryParticipantDeclarationsJob` job as it is no longer used. This appears to be the last of the jobs that uses the big query gem as opposed to dfe-analyitics, so we can remove that as well. Removes `GOOGLE_BQ_SERVICE_ACCOUNT_BASE64` from credentials.
ethax-ross
force-pushed
the
3986-remove-unused-bq-job
branch
from
411560c to
cae44a0
Compare
cwrw
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-3986
Context
We want to remove the
StreamBigQueryParticipantDeclarationsJobjob as it is no longer used.Changes proposed in this pull request
StreamBigQueryParticipantDeclarationsJobjob as it is no longer used.Guidance to review
Also removes
big_queryqueue and the scheduled cron job as well as the gem we were using.Removes
GOOGLE_BQ_SERVICE_ACCOUNT_BASE64from credentials.