Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BigQuery credentials #5497

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Remove BigQuery credentials #5497

merged 1 commit into from
Jan 30, 2025

Conversation

ethax-ross
Copy link
Collaborator

@ethax-ross ethax-ross commented Jan 29, 2025

Context

We now pass the dfe-analytics credentials as part of CI/terraform; we no longer need to specify them in the Rails credentials.

Changes proposed in this pull request

  • Remove BigQuery credentials

As we are not passing these in from the CI/terraform we no longer need to provide them as part of the Rails credentials.

Removes the following keys from review, sandbox, staging and production:

BIGQUERY_DFE_ANALYTICS_DATASET
BIGQUERY_DFE_ANALYTICS_API_JSON_KEY

Guidance to review

To make testing easier this is also removing the credentials that were used by the legacy BigQuery integration, which is being removed as part of #5496.

Checked by manually deploying to:

  • Review ✅
  • Staging ✅
  • Sandbox ✅
  • Production ✅

Then running a query such as:

SELECT occurred_at, request_query, request_path
FROM `ecf-bq.ecf_events_review.events` 
WHERE TIMESTAMP_TRUNC(occurred_at, DAY) = TIMESTAMP("2025-01-30") 
ORDER BY occurred_at 
DESC LIMIT 5

And hitting a path /users/sign_in?test=ross, which we should then see in the results:

Screenshot 2025-01-30 at 07 53 31

Copy link

Review app deployed to https://cpd-ecf-review-5497-web.test.teacherservices.cloud

As we are not passing these in from the CI/terraform we no longer need to provide them as part of the Rails credentials.

Removes the following keys from review, sandbox, staging and production:

```
BIGQUERY_DFE_ANALYTICS_DATASET
BIGQUERY_DFE_ANALYTICS_API_JSON_KEY
```
@ethax-ross ethax-ross force-pushed the remove-big-query-credentials branch from 17122f5 to 5551f74 Compare January 30, 2025 11:28
@ethax-ross ethax-ross marked this pull request as ready for review January 30, 2025 11:47
@ethax-ross ethax-ross added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 9245d97 Jan 30, 2025
39 checks passed
@ethax-ross ethax-ross deleted the remove-big-query-credentials branch January 30, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants