So/review sentry exception logging in the api #3647
Annotations
1 error and 10 warnings
sonarcloud
Process completed with exit code 1.
|
sonarcloud:
GetIntoTeachingApi/Program.cs#L39
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
sonarcloud:
GetIntoTeachingApi/Program.cs#L53
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
sonarcloud:
GetIntoTeachingApi/Jobs/FilterAttributes/CorrelationIdFilterAttribute.cs#L11
Specify AttributeUsage on 'CorrelationIdFilterAttribute' to improve readability, even though it inherits it from its base type. (https://rules.sonarsource.com/csharp/RSPEC-3993)
|
sonarcloud:
GetIntoTeachingApi/AppStart/Startup.cs#L100
Make sure this debug feature is deactivated before delivering the code in production. (https://rules.sonarsource.com/csharp/RSPEC-4507)
|
sonarcloud:
GetIntoTeachingApi/AppStart/ServiceCollectionExtensions.cs#L101
Refactor your code not to use hardcoded absolute paths or URIs. (https://rules.sonarsource.com/csharp/RSPEC-1075)
|
sonarcloud:
GetIntoTeachingApi/Controllers/TeacherTrainingAdviser/CandidatesController.cs#L134
Logging in a catch clause should pass the caught exception as a parameter. (https://rules.sonarsource.com/csharp/RSPEC-6667)
|
sonarcloud:
GetIntoTeachingApi/Models/SchoolsExperience/SchoolsExperienceSignUp.cs#L22
Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
|
sonarcloud:
GetIntoTeachingApi/Models/IAppSettings.cs#L9
Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
|
sonarcloud:
GetIntoTeachingApi/Models/TeacherTrainingAdviser/TeacherTrainingAdviserSignUp.cs#L90
Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
|
sonarcloud:
GetIntoTeachingApi/Controllers/TeacherTrainingAdviser/CandidatesController.cs#L21
This controller has multiple responsibilities and could be split into 2 smaller controllers. (https://rules.sonarsource.com/csharp/RSPEC-6960)
|