Split skylight metrics for review apps out per review app #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitemaeric
changed the base branch from
main
to
dd/remove-aks-from-rails-environments
Base automatically changed from
dd/remove-aks-from-rails-environments
to
main
November 21, 2024 10:44
Nitemaeric
force-pushed
the
dd/test-if-pr-number-is-available-in-code
branch
from
817fb05 to
e11af52
Compare
Nitemaeric
changed the title
Nitemaeric
force-pushed
the
dd/test-if-pr-number-is-available-in-code
branch
2 times, most recently
from
7d12cb5 to
69ee560
Compare
Nitemaeric
added
deploy
Nitemaeric
force-pushed
the
dd/test-if-pr-number-is-available-in-code
branch
2 times, most recently
from
b199472 to
bc2a2db
Compare
This will split out review environments so we don't have mixed logs from multiple review apps.
Nitemaeric
force-pushed
the
dd/test-if-pr-number-is-available-in-code
branch
from
bc2a2db to
d7182f2
Compare
Nitemaeric
changed the title
|
Nice work! Will these environments stack up over time or will they delete themselvers? |
Here's what Skylight has previously told me.
Which is a bit longer than we need, but better than never disappearing! |
tomas-stefano
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We can send our Skylight metrics for review apps out into separate environments. In the case that we want to understand the performance of a review app, we will be able to distinguish between each review app and its metrics.
Changes proposed in this pull request
Guidance to review