Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split skylight metrics for review apps out per review app #4697

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Split skylight metrics for review apps out per review app #4697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57858cd
Set APP_NAME_SUFFIX environment variable
Nitemaeric Nov 18, 2024
7bcc31b
Use APP_SUFFIX_NAME as review skylight environment
Nitemaeric Dec 11, 2024
d7182f2
Update phase banner text
Nitemaeric Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/phase_banner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def initialize(no_border: false)
end

def environment_label
Settings.environment.label.capitalize
Settings.environment.label
end

def environment_colour
Expand Down
2 changes: 2 additions & 0 deletions config/skylight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ ignored_endpoints:
- HeartbeatController#sha
deploy:
git_sha: <%= ENV["COMMIT_SHA"] %>
review:
env: <%= ENV["APP_NAME_SUFFIX"] %>
2 changes: 1 addition & 1 deletion terraform/aks/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ locals {
REDIS_CACHE_URL = module.redis_cache.url
REDIS_WORKER_URL = module.redis_worker.url
}
app_env_values = yamldecode(file(var.app_config_file))[var.app_environment]
app_env_values = merge(yamldecode(file(var.app_config_file))[var.app_environment], { APP_NAME_SUFFIX = local.app_name_suffix })
infra_secrets = yamldecode(module.secrets.map[var.key_vault_infra_secret_name])

statuscake_additional_hostnames = var.additional_hostnames != null ? tolist([for hostname in var.additional_hostnames : format("https://%s/ping", hostname)]) : null
Expand Down
Loading