Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated existing content and added help text decimal places for terms #40

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updated existing content and added help text decimal places for terms #40

wants to merge 4 commits into from
+30 −22

Conversation

PriyaNahar2
Copy link
Contributor

@PriyaNahar2 PriyaNahar2 commented Jan 17, 2025 •
edited
Loading

Induction period closure changed on all 3 pages: pass induction, fail induction and release.

Before and after screenshots:

Before After
Screenshot 2025-01-17 at 14 18 49 Screenshot 2025-01-17 at 16 29 10
Before After
Screenshot 2025-01-17 at 16 30 24 Screenshot 2025-01-17 at 16 29 47

@github-actions GitHub Actions
Copy link

Review app deployed to https://cpd-ec2-review-40-web.test.teacherservices.cloud

@PriyaNahar2
Copy link
Contributor Author

Removed full stop on grey help text on both pages:
Before and after screenshots:

Before After
Screenshot 2025-01-22 at 13 49 21 Screenshot 2025-01-22 at 13 48 30

Before and after screenshots:

Before After
Screenshot 2025-01-22 at 13 49 52 Screenshot 2025-01-22 at 13 57 46

cc @peteryates @emily-prudence-dfe

peteryates
peteryates approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@peteryates peteryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a definite improvement.

@peteryates peteryates requested a review from a team January 23, 2025 12:07
emily-prudence-dfe
emily-prudence-dfe approved these changes Jan 23, 2025
View reviewed changes
Copy link

@emily-prudence-dfe emily-prudence-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I can't get onto Extensions to check it on the review app. I don't think that's related to this ticket, though, as the link has also disappeared on staging. Screenshots look great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claire-hughez claire-hughez claire-hughez left review comments

@emily-prudence-dfe emily-prudence-dfe emily-prudence-dfe approved these changes

@peteryates peteryates peteryates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PriyaNahar2 @peteryates @claire-hughez @emily-prudence-dfe