Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated existing content and added help text decimal places for terms #40

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions app/views/appropriate_bodies/teachers/_outcome_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,23 @@
<%=
f.govuk_date_field :finished_on,
legend: {
text: "Enter the date #{Teachers::Name.new(@teacher).full_name} moved from #{@appropriate_body.name}"
text: "When did they move from #{@appropriate_body.name}?"
}
%>

<%=
f.govuk_number_field :number_of_terms,
f.govuk_number_field(:number_of_terms,
width: 4,
label: {
size: 'm',
text: "How many terms of induction did #{Teachers::Name.new(@teacher).full_name} spend with you?",
text: "How many terms of induction did they spend with you?"
},
hint: { text: "Enter partial terms of induction as a decimal number. For example, one term and a half should be given as 1.5 terms." }
hint: { text: "You can use up to one decimal place if the induction term is not a whole number. For example, for 2 and a half terms enter 2.5" }) do
%>

<p class="govuk-body">You’ll need to consider:</p>
<ul class="govuk-list govuk-list--bullet">
<li>the amount of induction time they’ve completed so far</li>
<li>their full-time equivalent (FTE) working patterns and any long periods of absence</li>
<li>if they have sufficient time in their current post which can count towards their induction</li>
</ul>
<% end %>
28 changes: 16 additions & 12 deletions app/views/appropriate_bodies/teachers/extensions/new.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<%
page_data(
title: "Add an Extension to an ECT's induction",
title: "How many terms do you want to extend #{Teachers::Name.new(@teacher).full_name}’s induction by?",
caption: Teachers::Name.new(@teacher).full_name,
caption_size: 'm',
backlink_href: ab_teacher_path(@teacher)
Expand All @@ -10,11 +10,22 @@
<div class="govuk-grid-row">
<div class="govuk-grid-column-full">
<p class="govuk-body">
Before recording an extension, a final assessment must have been completed by the ECT's School Induction Tutor or Headteacher, which provides a recommendation on the ECT's performance against the Teaching Standards. As an Appropriate Body, you must have made a final decision on whether to extend the induction on the basis of this recommendation.
You can only extend their induction if it has been assessed by a school induction tutor or headteacher.
</p>

<p class="govuk-body">You do not need to extend for things like:</p>

<ul class="govuk-list govuk-list--bullet">
<li>extended sick leave</li>
<li>maternity or paternity leave</li>
<li>statutory adoption leave</li>
<li>shared parental leave</li>
<li>parental bereavement leave</li>
<li>unpaid carer’s leave</li>
</ul>

<p class="govuk-body">
You do not need to record an extension when an induction needs to be extended due to a period of extended absence (an "automatic extension")
<%= Teachers::Name.new(@teacher).full_name %> can appeal an extension to their induction. You must tell them about their right to appeal and the appeal process.
</p>

<%= form_with(
Expand All @@ -26,18 +37,11 @@

<%= f.govuk_number_field(
:number_of_terms,
label: { text: "How many additional terms of induction do you need to add to #{Teachers::Name.new(@teacher).full_name}'s induction?", size: "m" },
width: 5,
min: 0.1,
max: 12.0,
step: 0.1,
hint: { text: "You can record the number of terms using up to one decimal place" }
label: { text: 'Enter number of terms', size: 'm' },
hint: { text: "You can use up to one decimal place if the induction term is not a whole number. For example, for 2 and a half terms enter 2.5" }
) %>

<p class="govuk-body">
An ECT may appeal an extension to their induction. You must advise the ECT of their right to appeal and provide them with information about who to appeal to, and the time limit for doing so. More information can be found here
</p>

<%= f.govuk_submit "Continue" %>
<% end %>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ def when_i_enter_the_finish_date
end

def and_i_enter_a_terms_value_of(number)
teacher_name = Teachers::Name.new(teacher).full_name
label = "How many terms of induction did #{teacher_name} spend with you?"
label = "How many terms of induction did they spend with you?"

page.get_by_label(label).fill(number.to_s)
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ def when_i_enter_the_finish_date
end

def and_i_enter_a_terms_value_of(number)
teacher_name = Teachers::Name.new(teacher).full_name
label = "How many terms of induction did #{teacher_name} spend with you?"
label = "How many terms of induction did they spend with you?"

page.get_by_label(label).fill(number.to_s)
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
get("/appropriate-body/teachers/#{teacher.trn}/extensions/new")

expect(response).to be_successful
expect(response.body).to include('Add an Extension to an ECT&#39;s induction')
expect(response.body).to include('Enter number of terms')
end
end

Expand Down
Loading