👷 Replace istanbul-instrumenter-loader with coverage-istanbul-loader #1020
Conversation
`istanbul-instrumenter-loader` library has been deprecated and its repository is now archived. It has been superseded by `coverage-istanbul-loader`. Additionally, it removes a warning that was more visible if one tried to use `npm` instead of `yarn`: ``` npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: browser-sdk@undefined npm ERR! Found: [email protected] npm ERR! node_modules/webpack npm ERR! dev webpack@"5.28.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from [email protected] npm ERR! node_modules/istanbul-instrumenter-loader npm ERR! dev istanbul-instrumenter-loader@"3.0.1" from the root project ```
|
|
|
Thanks for reporting this. It looks like since it doesn't specify a webpack version. We'll take a look. |
|
I agree it's not a perfect replacement but I could not find anything newer. I might look into opening a PR that bumps webpack to v5 later. But as you said, it does help with some existing warnings. |
This commit fixes `yarn audit` warnings by bumping some subdependencies minor versions. For some reason, yarn downgraded the versions while replacing the package.
BenoitZugmeyer
force-pushed
the
coverage-istanbul-loader
branch
from
ac16686 to
9338973
Compare
Codecov Report
@@ Coverage Diff @@
## main #1020 +/- ##
=======================================
Coverage 88.98% 88.98%
=======================================
Files 88 88
Lines 4122 4123 +1
Branches 946 946
=======================================
+ Hits 3668 3669 +1
Misses 454 454
Continue to review full report at Codecov.
|
|
This PR is superseded by #1023 (branches need to be on our own repository so the CI can be executed) |
Motivation
To keep up to date with latest versions of all libraries which include bug fixes and improvements.
Changes
This change removes a no longer supported library by replacing it with another.
Testing
I ran both
yarn test:unitandyarn test:e2e.I have gone over the contributing documentation.