👷 Replace istanbul-instrumenter-loader with coverage-istanbul-loader #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`istanbul-instrumenter-loader` library has been deprecated and its repository is now archived. It has been superseded by `coverage-istanbul-loader`. Additionally, it removes a warning that was more visible if one tried to use `npm` instead of `yarn`: ``` npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: browser-sdk@undefined npm ERR! Found: [email protected] npm ERR! node_modules/webpack npm ERR! dev webpack@"5.28.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from [email protected] npm ERR! node_modules/istanbul-instrumenter-loader npm ERR! dev istanbul-instrumenter-loader@"3.0.1" from the root project ```
This commit fixes `yarn audit` warnings by bumping some subdependencies minor versions. For some reason, yarn downgraded the versions while replacing the package.
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 88 88
Lines 4135 4136 +1
Branches 950 950
=======================================
+ Hits 3681 3682 +1
Misses 454 454
Continue to review full report at Codecov.
|
amortemousque
approved these changes
Sep 1, 2021
webNeat
approved these changes
Sep 1, 2021
|
Thank you @bpinto, it has been merged :) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is equivalent to #1020 but on the DataDog repo so CI can actually run.