Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update algoliasearch latest version to 4.11.2 #11841

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 29, 2024

Update algoliasearch lockfiles and dependency package lockfiles.
This performs the following updates:

  1. Some algoliasearch lockfiles use algoliasearch latest. This will update algoliasearch and dependencies.
  2. Some algoliasearch lockfiles use a pinned (non-latest) version of algoliasearch, but require the latest version of another package. This will update all such packages.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot requested a review from a team as a code owner December 29, 2024 00:19
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 29, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 29, 2024

Benchmarks

Benchmark execution time: 2025-01-06 18:05:29

Comparing candidate commit c731cef in PR branch upgrade-latest-algoliasearch-version with baseline commit 6bfe77e in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics.

scenario:iast_aspects-replace_aspect

  • 🟥 execution_time [+594.232ns; +677.435ns] or [+8.845%; +10.084%]

@emmettbutler emmettbutler enabled auto-merge (squash) January 6, 2025 17:21
Copy link
Contributor Author

github-actions bot commented Jan 6, 2025

CODEOWNERS have been resolved as:

.riot/requirements/14be2f6.txt                                          @DataDog/apm-python
.riot/requirements/1a06ac7.txt                                          @DataDog/apm-python
.riot/requirements/1b0d918.txt                                          @DataDog/apm-python
.riot/requirements/1ccf91d.txt                                          @DataDog/apm-python
.riot/requirements/404933a.txt                                          @DataDog/apm-python
.riot/requirements/b80e42b.txt                                          @DataDog/apm-python
.riot/requirements/cc2f3f8.txt                                          @DataDog/apm-python
.riot/requirements/e1220d6.txt                                          @DataDog/apm-python
.riot/requirements/feaf737.txt                                          @DataDog/apm-python

@@ -5,21 +5,21 @@
# pip-compile --allow-unsafe --no-annotate .riot/requirements/14be2f6.in
#
algoliasearch==2.6.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't actually update algoliasearch to 4.11.2. It just bumps some transitive dependencies. There is likely a bug in the script.

cc: @quinna-h @bouwkast

Copy link
Contributor

@bouwkast bouwkast Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct algoliasearch is a pinned package for dd-trace-py and shouldn't be updated.

@quinna-h I see the workflow outputting the following as updateable:

algoliasearch botocore starlette coverage tornado aiohttp falcon anthropic logbook pynamodb langchain urllib3 dramatiq jinja2 django protobuf flask aiobotocore openai

Maybe something wrong going on in here?

def _venv_sets_latest_for_package(venv: riotfile.Venv, suite_name: str) -> bool:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages = {m for m in modules if "." not in m}

Needs to check for the pinned versions
->

packages = {m for m in modules if "." not in m and m not in pinned_packages}

Copy link
Contributor

@quinna-h quinna-h Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11864 - the logic in #11372 accidentally removed this check.

Copy link
Contributor

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes don't match the PR title

@quinna-h
Copy link
Contributor

quinna-h commented Jan 6, 2025

Fix #11868 was merged - this PR should not have been generated in the first place (and will not be in the future). Closing the PR.

@quinna-h quinna-h closed this Jan 6, 2025
auto-merge was automatically disabled January 6, 2025 23:51

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants