-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update algoliasearch latest version to 4.11.2 #11841
Conversation
BenchmarksBenchmark execution time: 2025-01-06 18:05:29 Comparing candidate commit c731cef in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics. scenario:iast_aspects-replace_aspect
|
|
@@ -5,21 +5,21 @@ | |||
# pip-compile --allow-unsafe --no-annotate .riot/requirements/14be2f6.in | |||
# | |||
algoliasearch==2.6.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct algoliasearch
is a pinned package for dd-trace-py
and shouldn't be updated.
@quinna-h I see the workflow outputting the following as updateable:
algoliasearch botocore starlette coverage tornado aiohttp falcon anthropic logbook pynamodb langchain urllib3 dramatiq jinja2 django protobuf flask aiobotocore openai
Maybe something wrong going on in here?
dd-trace-py/scripts/freshvenvs.py
Line 201 in 81208cd
def _venv_sets_latest_for_package(venv: riotfile.Venv, suite_name: str) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dd-trace-py/scripts/freshvenvs.py
Line 126 in 81208cd
packages = {m for m in modules if "." not in m} |
Needs to check for the pinned versions
->
packages = {m for m in modules if "." not in m and m not in pinned_packages}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes don't match the PR title
Fix #11868 was merged - this PR should not have been generated in the first place (and will not be in the future). Closing the PR. |
Pull request was closed
Update algoliasearch lockfiles and dependency package lockfiles.
This performs the following updates:
latest
. This will update algoliasearch and dependencies.latest
version of another package. This will update all such packages.Checklist
Reviewer Checklist