Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update algoliasearch latest version to 4.11.2 #11841

Closed
wants to merge 2 commits into from
Closed

chore: update algoliasearch latest version to 4.11.2 #11841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27d0196
Update package version
quinna-h Dec 29, 2024
c731cef
Merge branch 'main' into upgrade-latest-algoliasearch-version
emmettbutler Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .riot/requirements/14be2f6.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@
# pip-compile --allow-unsafe --no-annotate .riot/requirements/14be2f6.in
#
algoliasearch==2.6.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't actually update algoliasearch to 4.11.2. It just bumps some transitive dependencies. There is likely a bug in the script.

cc: @quinna-h @bouwkast

Copy link
Contributor

@bouwkast bouwkast Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct algoliasearch is a pinned package for dd-trace-py and shouldn't be updated.

@quinna-h I see the workflow outputting the following as updateable:

algoliasearch botocore starlette coverage tornado aiohttp falcon anthropic logbook pynamodb langchain urllib3 dramatiq jinja2 django protobuf flask aiobotocore openai

Maybe something wrong going on in here?

dd-trace-py/scripts/freshvenvs.py

Line 201 in 81208cd

def _venv_sets_latest_for_package(venv: riotfile.Venv, suite_name: str) -> bool:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dd-trace-py/scripts/freshvenvs.py

Line 126 in 81208cd

packages = {m for m in modules if "." not in m}

Needs to check for the pinned versions
->

packages = {m for m in modules if "." not in m and m not in pinned_packages}

Copy link
Contributor

@quinna-h quinna-h Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11864 - the logic in #11372 accidentally removed this check.

attrs==24.2.0
certifi==2024.8.30
charset-normalizer==3.3.2
coverage[toml]==7.6.1
attrs==24.3.0
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.6.10
hypothesis==6.45.0
idna==3.10
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.1
packaging==24.2
pluggy==1.5.0
pytest==8.3.3
pytest-cov==5.0.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
pytest-randomly==3.15.0
pytest-randomly==3.16.0
requests==2.32.3
sortedcontainers==2.4.0
urllib3==1.26.20
8 changes: 4 additions & 4 deletions .riot/requirements/1a06ac7.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
#
algoliasearch==2.6.3
attrs==24.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.2.7
exceptiongroup==1.2.2
hypothesis==6.45.0
idna==3.8
idna==3.10
importlib-metadata==6.7.0
iniconfig==2.0.0
mock==5.1.0
Expand All @@ -26,5 +26,5 @@ requests==2.31.0
sortedcontainers==2.4.0
tomli==2.0.1
typing-extensions==4.7.1
urllib3==1.26.19
urllib3==1.26.20
zipp==3.15.0
20 changes: 10 additions & 10 deletions .riot/requirements/1b0d918.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,25 @@
# pip-compile --allow-unsafe --no-annotate .riot/requirements/1b0d918.in
#
algoliasearch==2.6.3
attrs==24.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
attrs==24.3.0
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.6.1
exceptiongroup==1.2.2
hypothesis==6.45.0
idna==3.8
importlib-metadata==8.4.0
idna==3.10
importlib-metadata==8.5.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.1
packaging==24.2
pluggy==1.5.0
pytest==8.3.2
pytest==8.3.4
pytest-cov==5.0.0
pytest-mock==3.14.0
pytest-randomly==3.15.0
requests==2.32.3
sortedcontainers==2.4.0
tomli==2.0.1
urllib3==1.26.19
zipp==3.20.0
tomli==2.2.1
urllib3==1.26.20
zipp==3.20.2
22 changes: 11 additions & 11 deletions .riot/requirements/1ccf91d.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@
# pip-compile --allow-unsafe --no-annotate .riot/requirements/1ccf91d.in
#
algoliasearch==2.6.3
attrs==24.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
coverage[toml]==7.6.1
attrs==24.3.0
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.6.10
exceptiongroup==1.2.2
hypothesis==6.45.0
idna==3.8
idna==3.10
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.1
packaging==24.2
pluggy==1.5.0
pytest==8.3.2
pytest-cov==5.0.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
pytest-randomly==3.15.0
pytest-randomly==3.16.0
requests==2.32.3
sortedcontainers==2.4.0
tomli==2.0.1
urllib3==1.26.19
tomli==2.2.1
urllib3==1.26.20
20 changes: 10 additions & 10 deletions .riot/requirements/404933a.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@
# pip-compile --allow-unsafe --no-annotate .riot/requirements/404933a.in
#
algoliasearch==2.6.3
attrs==24.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
coverage[toml]==7.6.1
attrs==24.3.0
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.6.10
hypothesis==6.45.0
idna==3.8
idna==3.10
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.1
packaging==24.2
pluggy==1.5.0
pytest==8.3.2
pytest-cov==5.0.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
pytest-randomly==3.15.0
pytest-randomly==3.16.0
requests==2.32.3
sortedcontainers==2.4.0
urllib3==1.26.19
urllib3==1.26.20
20 changes: 10 additions & 10 deletions .riot/requirements/b80e42b.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,25 @@
# pip-compile --allow-unsafe --no-annotate .riot/requirements/b80e42b.in
#
algoliasearch==2.6.3
attrs==24.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
attrs==24.3.0
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.6.1
exceptiongroup==1.2.2
hypothesis==6.45.0
idna==3.8
importlib-metadata==8.4.0
idna==3.10
importlib-metadata==8.5.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.1
packaging==24.2
pluggy==1.5.0
pytest==8.3.2
pytest==8.3.4
pytest-cov==5.0.0
pytest-mock==3.14.0
pytest-randomly==3.15.0
requests==2.32.3
sortedcontainers==2.4.0
tomli==2.0.1
urllib3==1.26.19
zipp==3.20.0
tomli==2.2.1
urllib3==1.26.20
zipp==3.20.2
26 changes: 13 additions & 13 deletions .riot/requirements/cc2f3f8.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,25 @@
# pip-compile --allow-unsafe --no-annotate .riot/requirements/cc2f3f8.in
#
algoliasearch==2.6.3
attrs==24.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
coverage[toml]==7.6.1
attrs==24.3.0
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.6.10
exceptiongroup==1.2.2
hypothesis==6.45.0
idna==3.8
importlib-metadata==8.4.0
idna==3.10
importlib-metadata==8.5.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.1
packaging==24.2
pluggy==1.5.0
pytest==8.3.2
pytest-cov==5.0.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
pytest-randomly==3.15.0
pytest-randomly==3.16.0
requests==2.32.3
sortedcontainers==2.4.0
tomli==2.0.1
urllib3==1.26.19
zipp==3.20.0
tomli==2.2.1
urllib3==1.26.20
zipp==3.21.0
20 changes: 10 additions & 10 deletions .riot/requirements/e1220d6.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@
# pip-compile --allow-unsafe --no-annotate .riot/requirements/e1220d6.in
#
algoliasearch==2.6.3
attrs==24.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
coverage[toml]==7.6.1
attrs==24.3.0
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.6.10
hypothesis==6.45.0
idna==3.8
idna==3.10
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.1
packaging==24.2
pluggy==1.5.0
pytest==8.3.2
pytest-cov==5.0.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
pytest-randomly==3.15.0
pytest-randomly==3.16.0
requests==2.32.3
sortedcontainers==2.4.0
urllib3==1.26.19
urllib3==1.26.20
8 changes: 4 additions & 4 deletions .riot/requirements/feaf737.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
#
algoliasearch==2.6.3
attrs==24.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
certifi==2024.12.14
charset-normalizer==3.4.1
coverage[toml]==7.2.7
exceptiongroup==1.2.2
hypothesis==6.45.0
idna==3.8
idna==3.10
importlib-metadata==6.7.0
iniconfig==2.0.0
mock==5.1.0
Expand All @@ -26,5 +26,5 @@ requests==2.31.0
sortedcontainers==2.4.0
tomli==2.0.1
typing-extensions==4.7.1
urllib3==1.26.19
urllib3==1.26.20
zipp==3.15.0
Loading