Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(langgraph): fix flaky test #12024

Merged
merged 3 commits into from
Jan 22, 2025
Merged

ci(langgraph): fix flaky test #12024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88c5553
fix llmobs tests
sabrenner Jan 22, 2025
28de3a4
possibly fix apm tests
sabrenner Jan 22, 2025
bff15d2
fmt
sabrenner Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 64 additions & 39 deletions tests/contrib/langgraph/test_langgraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,134 +1,159 @@
from collections import Counter


def assert_has_spans(spans, expected):
resources = [span.resource for span in spans]
assert len(resources) == len(expected)
assert Counter(resources) == Counter(expected)


def assert_simple_graph_spans(spans):
assert len(spans) == 3
assert spans[0].resource == "langgraph.graph.state.CompiledStateGraph.LangGraph"
assert spans[1].resource == "langgraph.utils.runnable.RunnableSeq.a"
assert spans[2].resource == "langgraph.utils.runnable.RunnableSeq.b"
assert_has_spans(
spans,
expected=[
"langgraph.graph.state.CompiledStateGraph.LangGraph",
"langgraph.utils.runnable.RunnableSeq.a",
"langgraph.utils.runnable.RunnableSeq.b",
],
)


def assert_conditional_graph_spans(spans, which):
assert len(spans) == 3
assert spans[0].resource == "langgraph.graph.state.CompiledStateGraph.LangGraph"
assert spans[1].resource == "langgraph.utils.runnable.RunnableSeq.a"
assert spans[2].resource == f"langgraph.utils.runnable.RunnableSeq.{which}"
assert_has_spans(
spans,
expected=[
"langgraph.graph.state.CompiledStateGraph.LangGraph",
"langgraph.utils.runnable.RunnableSeq.a",
f"langgraph.utils.runnable.RunnableSeq.{which}",
],
)


def assert_subgraph_spans(spans):
assert len(spans) == 6
assert spans[0].resource == "langgraph.graph.state.CompiledStateGraph.LangGraph"
assert spans[1].resource == "langgraph.utils.runnable.RunnableSeq.a"
assert spans[2].resource == "langgraph.graph.state.CompiledStateGraph.LangGraph"
assert spans[3].resource == "langgraph.utils.runnable.RunnableSeq.b1"
assert spans[4].resource == "langgraph.utils.runnable.RunnableSeq.b2"
assert spans[5].resource == "langgraph.utils.runnable.RunnableSeq.b3"
assert_has_spans(
spans,
expected=[
"langgraph.graph.state.CompiledStateGraph.LangGraph",
"langgraph.utils.runnable.RunnableSeq.a",
"langgraph.graph.state.CompiledStateGraph.LangGraph",
"langgraph.utils.runnable.RunnableSeq.b1",
"langgraph.utils.runnable.RunnableSeq.b2",
"langgraph.utils.runnable.RunnableSeq.b3",
],
)


def assert_fanning_graph_spans(spans):
assert len(spans) == 5
assert spans[0].resource == "langgraph.graph.state.CompiledStateGraph.LangGraph"
assert spans[1].resource == "langgraph.utils.runnable.RunnableSeq.a"
assert spans[2].resource == "langgraph.utils.runnable.RunnableSeq.b"
assert spans[3].resource == "langgraph.utils.runnable.RunnableSeq.c"
assert spans[4].resource == "langgraph.utils.runnable.RunnableSeq.d"


def test_simple_graph(langgraph, simple_graph, mock_tracer):
assert_has_spans(
spans,
expected=[
"langgraph.graph.state.CompiledStateGraph.LangGraph",
"langgraph.utils.runnable.RunnableSeq.a",
"langgraph.utils.runnable.RunnableSeq.b",
"langgraph.utils.runnable.RunnableSeq.c",
"langgraph.utils.runnable.RunnableSeq.d",
],
)


def test_simple_graph(simple_graph, mock_tracer):
simple_graph.invoke({"a_list": [], "which": "a"})
spans = mock_tracer.pop_traces()[0]
assert_simple_graph_spans(spans)


async def test_simple_graph_async(langgraph, simple_graph, mock_tracer):
async def test_simple_graph_async(simple_graph, mock_tracer):
await simple_graph.ainvoke({"a_list": [], "which": "a"})
spans = mock_tracer.pop_traces()[0]
assert_simple_graph_spans(spans)


def test_simple_graph_stream(langgraph, simple_graph, mock_tracer):
def test_simple_graph_stream(simple_graph, mock_tracer):
for _ in simple_graph.stream({"a_list": [], "which": "a"}):
pass
spans = mock_tracer.pop_traces()[0]
assert_simple_graph_spans(spans)


async def test_simple_graph_stream_async(langgraph, simple_graph, mock_tracer):
async def test_simple_graph_stream_async(simple_graph, mock_tracer):
async for _ in simple_graph.astream({"a_list": [], "which": "a"}):
pass
spans = mock_tracer.pop_traces()[0]
assert_simple_graph_spans(spans)


def test_conditional_graph(langgraph, conditional_graph, mock_tracer):
def test_conditional_graph(conditional_graph, mock_tracer):
conditional_graph.invoke({"a_list": [], "which": "c"})
spans = mock_tracer.pop_traces()[0]
assert_conditional_graph_spans(spans, which="c")


async def test_conditional_graph_async(langgraph, conditional_graph, mock_tracer):
async def test_conditional_graph_async(conditional_graph, mock_tracer):
await conditional_graph.ainvoke({"a_list": [], "which": "b"})
spans = mock_tracer.pop_traces()[0]
assert_conditional_graph_spans(spans, which="b")


def test_conditional_graph_stream(langgraph, conditional_graph, mock_tracer):
def test_conditional_graph_stream(conditional_graph, mock_tracer):
for _ in conditional_graph.stream({"a_list": [], "which": "c"}):
pass
spans = mock_tracer.pop_traces()[0]
assert_conditional_graph_spans(spans, which="c")


async def test_conditional_graph_stream_async(langgraph, conditional_graph, mock_tracer):
async def test_conditional_graph_stream_async(conditional_graph, mock_tracer):
async for _ in conditional_graph.astream({"a_list": [], "which": "b"}):
pass
spans = mock_tracer.pop_traces()[0]
assert_conditional_graph_spans(spans, which="b")


def test_subgraph(langgraph, complex_graph, mock_tracer):
def test_subgraph(complex_graph, mock_tracer):
complex_graph.invoke({"a_list": [], "which": "b"})
spans = mock_tracer.pop_traces()[0]
assert_subgraph_spans(spans)


async def test_subgraph_async(langgraph, complex_graph, mock_tracer):
async def test_subgraph_async(complex_graph, mock_tracer):
await complex_graph.ainvoke({"a_list": [], "which": "b"})
spans = mock_tracer.pop_traces()[0]
assert_subgraph_spans(spans)


def test_subgraph_stream(langgraph, complex_graph, mock_tracer):
def test_subgraph_stream(complex_graph, mock_tracer):
for _ in complex_graph.stream({"a_list": [], "which": "b"}):
pass
spans = mock_tracer.pop_traces()[0]
assert_subgraph_spans(spans)


async def test_subgraph_stream_async(langgraph, complex_graph, mock_tracer):
async def test_subgraph_stream_async(complex_graph, mock_tracer):
async for _ in complex_graph.astream({"a_list": [], "which": "b"}):
pass
spans = mock_tracer.pop_traces()[0]
assert_subgraph_spans(spans)


def test_fanning_graph(langgraph, fanning_graph, mock_tracer):
def test_fanning_graph(fanning_graph, mock_tracer):
fanning_graph.invoke({"a_list": [], "which": "b"})
spans = mock_tracer.pop_traces()[0]
assert_fanning_graph_spans(spans)


async def test_fanning_graph_async(langgraph, fanning_graph, mock_tracer):
async def test_fanning_graph_async(fanning_graph, mock_tracer):
await fanning_graph.ainvoke({"a_list": [], "which": "b"})
spans = mock_tracer.pop_traces()[0]
assert_fanning_graph_spans(spans)


def test_fanning_graph_stream(langgraph, fanning_graph, mock_tracer):
def test_fanning_graph_stream(fanning_graph, mock_tracer):
for _ in fanning_graph.stream({"a_list": [], "which": "b"}):
pass
spans = mock_tracer.pop_traces()[0]
assert_fanning_graph_spans(spans)


async def test_fanning_graph_stream_async(langgraph, fanning_graph, mock_tracer):
async def test_fanning_graph_stream_async(fanning_graph, mock_tracer):
async for _ in fanning_graph.astream({"a_list": [], "which": "b"}):
pass
spans = mock_tracer.pop_traces()[0]
Expand Down
Loading
Loading