Feature/add measure tool #124

LDWiegand · 2024-04-18T07:54:50Z

Summary

Added a measure tool for distances and areas

Instructions for local reproduction and review

npm run snowbox

- README has been added - CHANGELOG/package.json have been changed to alpha release

Co-authored-by: Finn-Rasmus Darge <[email protected]>

…/add-measure-tool

By adding these two, it is now possible to measure lengths and areas and not triggering the pins plugin or the directSelect of gfi. If one wants to use more complex interactions, they may remove the measure interactions by selecting "No interaction". This still leaves room open for draw and measure to work together, but this may be a wanted situation. If not, this can be removed by simply toggling the respective plugin.

dopenguin · 2024-12-30T11:03:33Z

@warm-coolguy I've added the relevant parts that were missing here.
However, I've decided against adding a mechanism in @polar/core and went with the route we've already established between @polar/plugin-pins and @polar/plugin-draw.

Let me know if you've got any questions!

dopenguin · 2024-12-30T11:04:44Z

Also, on another note, I'll tackle the TODOs in packages/plugins/Measure/src/components/Measure.vue soon! - Done 3a0472b

warm-coolguy

🏓 @dopenguin

After reviewing and summing up my findings I find that an awful lot of my comments is about making this implementation more like Draw. A lot of problems we have here have already been solved in Draw, and all that progress is lost on this re-implementation and would have to be redone samishly. (After all, Draw is the result of a lot of work over a long period of time, and we're on the third-or-so implementation here, learning incrementally.)

This makes me really wonder if Draw could just add, by configuration, another radio box section like pseudo-HTML:

h3. Measurement
  radio. None
  radio. m, m²
  radio. km, km²
  radio. km, ha

When active, lines would show lengths (and maybe length sum), areas lengths and area, and circles area and maybe circumference or diameter or whatever.

What do you think about this?

packages/plugins/Draw/package.json

packages/plugins/Measure/README.md

warm-coolguy · 2025-01-06T12:11:17Z

packages/plugins/Measure/src/utils/createStyle.ts

+  new Style({
+    stroke: new Stroke({ color: textColor, width: lineWidth / 5 }),
+    text: new Text({
+      font: 'bold 14px cursive',


I propose that the font (and, for that, all fields configurable in OL for Text) should be configurable, and don't consider the current defaults to work well.

I'm having issues reading this due to its fat/self-overlapping nature. While the problem can't be solved in general for all backgrounds, it can be solved better.

Agreed, will add and adjust those!

packages/core/CHANGELOG.md

packages/plugins/Gfi/src/store/actions/index.ts

warm-coolguy · 2025-01-06T12:50:47Z

packages/plugins/Measure/src/store/actions/createInteractions.ts

+      interactions.push(modify)
+      styleFunc = specialStyle
+    } else if (mode === 'delete') {
+      interactions = await dispatch('createDeleteInteraction', drawSource)


There is an effect on the edges that makes it seem like they can be interacted with, but nothing happens on clicks. That's confusing.

Adjusted 8b7258f

warm-coolguy · 2025-01-06T12:51:54Z

packages/plugins/Measure/src/store/actions/createInteractions.ts

+    interactions.push(draw)
+  } else if (drawSource.getFeatures().length > 0) {
+    if (mode === 'edit') {
+      const modify = getModify(drawSource)


The modify does not yield any effects on the map, making it hard to see whether clicking will be effective. I propose the same effect as used in the Draw plugin should be used.

Will add that!

warm-coolguy · 2025-01-06T12:55:05Z

packages/plugins/Measure/src/store/actions/createDeleteInteraction/index.ts

+  if (pointAmount < minimum) {
+    drawSource.removeFeature(feature)
+    dispatch('setSelectedFeature', null)
+    return
+  }


Deletion in Measure differs to how Deletion in Draw works. Here, only corner points are deleted, and the feature is kept intact as long as possible. In Draw, we just delete whole features that are clicked, which seems to be the more reasonable behaviour to me.

I thought the implementation added was quite neat and left it as is. But I have no strong feelings and will adjust it.

packages/plugins/Measure/src/store/actions/createInteractions.ts

warm-coolguy · 2025-01-06T13:01:16Z

packages/plugins/Measure/src/store/actions/createStyleFunc.ts

+    delete: {
+      // larger lines and points
+      lineWidth: 4,
+      pointWidth: 5,
+    },


I don't understand why lines should be fatter when starting a deletion albeit being exactly the elements the user is not supposed to interact with.

See #124 (comment)

dopenguin · 2025-01-06T14:06:28Z

🏓 @dopenguin

After reviewing and summing up my findings I find that an awful lot of my comments is about making this implementation more like Draw. A lot of problems we have here have already been solved in Draw, and all that progress is lost on this re-implementation and would have to be redone samishly. (After all, Draw is the result of a lot of work over a long period of time, and we're on the third-or-so implementation here, learning incrementally.)

This makes me really wonder if Draw could just add, by configuration, another radio box section like pseudo-HTML:
h3. Measurement
  radio. None
  radio. m, m²
  radio. km, km²
  radio. km, ha
When active, lines would show lengths (and maybe length sum), areas lengths and area, and circles area and maybe circumference or diameter or whatever.

What do you think about this?

I thought, so far, that that would be an effort we are not taking right now but in the near future. Maybe we should discuss this before this PR gets merged though.

Edit: Before moving forward, adjusting everything to be like Draw, I agree that we should take a look on how some added things here may be added to Draw now instead of the future. Let's ☎️ about this soon!

Co-authored-by: Dennis Sen <[email protected]>

LDWiegand added 5 commits April 10, 2024 09:04

Measure Tool working for Distances

8da31e4

Added Area

5fabc3a

Measure with Geometry.getLength and getArea()

95b1c7c

Renaming the tool

b65e333

Merge create-Folders in utils + Comments

d8efe41

LDWiegand added the enhancement New feature or request label Apr 18, 2024

LDWiegand self-assigned this Apr 18, 2024

warm-coolguy self-assigned this Apr 18, 2024

warm-coolguy requested a review from dopenguin April 18, 2024 08:32

LDWiegand and others added 5 commits April 18, 2024 11:13

Removing the Dataportal-Client, fixing the Distance/Area-Switch

1c5022b

Fix Lint-Errors

98b68f4

Syntax Changes + Comments

9db8643

add measure plugin to snowbox's package.json

a676f90

update the top level documentation files

c6beefa

- README has been added - CHANGELOG/package.json have been changed to alpha release

warm-coolguy force-pushed the feature/add-measure-tool branch from 4304b17 to 9197c6c Compare April 26, 2024 09:10

add error message on invalid geometry

17e61c2

Co-authored-by: Finn-Rasmus Darge <[email protected]>

warm-coolguy force-pushed the feature/add-measure-tool branch from 9197c6c to 17e61c2 Compare April 26, 2024 09:13

warm-coolguy and others added 12 commits April 26, 2024 11:22

remove unpublished dependency

c90e79e

fix naming in comments

4ed5022

add missing i18n

5a84d61

fix unnecessary vertical scrollbar in FF

249f1d1

change vue file name scheme to usual naming

108d372

refactor code to meet lint requirements

5f2c8c0

Co-authored-by: Finn-Rasmus Darge <[email protected]>

add linting override for list-like functions

000b98b

remove error log (exit condition is workflow part)

45e06b3

refactor to meet linting criteria

682308c

refactor to meet lint criteria

a110a52

refactor to meet linting requirements

7b985d9

Merge branch 'main' of https://github.com/Dataport/polar into feature…

66a5b96

…/add-measure-tool

warm-coolguy marked this pull request as ready for review April 29, 2024 06:30

dopenguin added 3 commits December 30, 2024 10:27

Fix issue of directSelect working if draw is enabled

05fa7c1

Move action setupTooltip to a separate file to adhere to linting rules

058d88a

dopenguin self-assigned this Dec 30, 2024

dopenguin removed their request for review December 30, 2024 11:03

Use external package to be able to convert all hex values to rgb(a)

9fe6fa8

dopenguin self-requested a review as a code owner December 30, 2024 11:13

dopenguin and others added 5 commits December 30, 2024 17:32

Fix issue of some lines not being deleted

e1fd916

Add information on how the deletion process works

3a0472b

Move actions to the correct place and ease usage of parameters

60a5cf1

Merge branch 'main' into feature/add-measure-tool

cc58d24

Merge branch 'main' into feature/add-measure-tool

196fea6

dopenguin mentioned this pull request Jan 6, 2025

Extend multi selection by adding new mode "circle" #211

Open

Merge branch 'main' into feature/add-measure-tool

234cf9d

warm-coolguy requested changes Jan 6, 2025

View reviewed changes

dopenguin added 2 commits January 6, 2025 14:59

Move @polar/core to be a peerDependency instead of a dependency

1f93fdb

Add used getters as documented values

9c749c4

dopenguin and others added 4 commits January 6, 2025 15:45

Use includes instead of indexOf

df4c565

Co-authored-by: Dennis Sen <[email protected]>

Rephrase German translation to be more polite

640d5a2

Adjust min-width to remove linebreak on no selection

6a19439

Fix linting error added in df4c565

e2d7079

dopenguin force-pushed the feature/add-measure-tool branch from 32b7b5c to e2d7079 Compare January 6, 2025 14:57

dopenguin added 5 commits January 6, 2025 16:08

Add units to locales

7efb08e

Remove unused method

6538e6f

Remove adjusted styling of lines in delete mode

8b7258f

Rename specialStyle to currentModeStyle

6099fe1

Merge branch 'main' into feature/add-measure-tool

2722da6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/add measure tool #124

Feature/add measure tool #124

LDWiegand commented Apr 18, 2024 •

edited by warm-coolguy

Loading

dopenguin commented Dec 30, 2024

dopenguin commented Dec 30, 2024 •

edited

Loading

warm-coolguy left a comment •

edited

Loading

warm-coolguy Jan 6, 2025

dopenguin Jan 6, 2025 •

edited

Loading

warm-coolguy Jan 6, 2025

dopenguin Jan 6, 2025

warm-coolguy Jan 6, 2025

dopenguin Jan 6, 2025

warm-coolguy Jan 6, 2025

dopenguin Jan 6, 2025

warm-coolguy Jan 6, 2025

dopenguin Jan 6, 2025

dopenguin commented Jan 6, 2025 •

edited

Loading

Feature/add measure tool #124

Are you sure you want to change the base?

Feature/add measure tool #124

Conversation

LDWiegand commented Apr 18, 2024 • edited by warm-coolguy Loading

Summary

Instructions for local reproduction and review

dopenguin commented Dec 30, 2024

dopenguin commented Dec 30, 2024 • edited Loading

warm-coolguy left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dopenguin Jan 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dopenguin commented Jan 6, 2025 • edited Loading

LDWiegand commented Apr 18, 2024 •

edited by warm-coolguy

Loading

dopenguin commented Dec 30, 2024 •

edited

Loading

warm-coolguy left a comment •

edited

Loading

dopenguin Jan 6, 2025 •

edited

Loading

dopenguin commented Jan 6, 2025 •

edited

Loading