Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add measure tool #124
base: main
Are you sure you want to change the base?
Feature/add measure tool #124
Changes from all commits
8da31e4
5fabc3a
95b1c7c
b65e333
d8efe41
1c5022b
98b68f4
9db8643
a676f90
c6beefa
17e61c2
c90e79e
4ed5022
5a84d61
249f1d1
108d372
5f2c8c0
000b98b
45e06b3
682308c
a110a52
7b985d9
66a5b96
aab4117
053cf74
398590f
4b2db52
b197cf5
60a1651
a18213a
5c847e6
fbd995c
1197b9c
244c7a5
3c81249
7d42e2c
04b1e44
7f0211b
942cf80
fd18527
8c95d66
7a75d6d
1377a1d
9aeb501
e491ce2
4cbd82f
7ad4fb7
0da5baf
9e84f1f
0195e81
fd16d83
e8395b1
67df0c3
d823408
6922d28
b1160b3
71d90cb
f23463e
d9c87db
76c9e0f
feadbdc
b4399f7
05fa7c1
58c3881
058d88a
9fe6fa8
e1fd916
3a0472b
60a5cf1
cc58d24
196fea6
234cf9d
1f93fdb
9c749c4
df4c565
640d5a2
6a19439
e2d7079
7efb08e
6538e6f
8b7258f
6099fe1
2722da6
c0d8153
9241dda
120fb5f
e9ab080
775f4db
452926f
b1a1d60
7b867de
6211874
ba62b3f
c51dd95
35c5542
fe57ab4
f318e29
9dfba44
f78bf70
08b8b25
cdf7047
372e960
24e386b
b32ee58
d28bb91
58b15cd
9597c25
7aebb05
cc34f1b
28193f9
518918d
e5c2485
05194aa
4089d78
8087760
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this part of the
@polar/components
package? While that package was a little pointless for theMoveHandle.vue
since that's only used in the core after all,RadioCard.vue
seems to be a good general-purpose component that might finde reuse in other plugins later, and putting it in the components package will result in a nicer dependency graph.But I remember we talked about this previously, and maybe I forgot some conclusion we came to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last year, in the wake of #108, we had decided to deprecate
@polar/components
and moveMoveHandle.vue
to@polar/core
. As that branch has not been merged yet, that change is not reflected in the current state.IMO, having reusable components in either place seems fine. However, I currently lean towards
@polar/core
as that package will always be a part of any client and any plugin can rely that@polar/core
exists.On the other hand, it seems fitting to place it in a separate package to be inline with the current architecture and have a better separation of concerns.
I believe it may seem fitting to ☎️ and lay out the pros and cons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"km / km²" and "km / ha" are redundant in
LineString
mode. I propose we reduce the available options' display texts to "m" and "km" only.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, something I forgot to add yesterday. Was still on my stack - will add this!