Fixed wrong empty line height #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inverse negative descent to calculate the height of an empty line correctly. Also renamed lineGap to emptyLineHeight to avoid confusion with semantically different lineGap as defined in TrueType etc.
|
The test "widgets-table" failing on page 25 makes sense with this PR. The attached illustration demonstrates the change, and how now, the output makes more sense. There should be two empty lines in the generated pdf, while clearly, with the current state, two lines would not fit within the free space. With the change, the lines would fit. (right side)
|
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negating negative descent to calculate the height of an empty line correctly.
Also renamed lineGap to emptyLineHeight to avoid confusion with semantically different lineGap as known from TrueType etc.