Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong empty line height #1594

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fixed wrong empty line height #1594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pdf/lib/src/pdf/obj/font.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ See https://github.com/DavBfr/dart_pdf/wiki/Fonts-Management
double get descent;

/// Height of an empty line
double get lineGap => ascent + descent;
double get emptyLineHeight => ascent + (-descent);

/// Internal units per
int get unitsPerEm;
Expand Down
3 changes: 2 additions & 1 deletion pdf/lib/src/widgets/text.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,8 @@ class RichText extends Widget with SpanningWidget {
if (spanCount > 0) {
offsetY += bottom - top;
} else {
offsetY += font.lineGap * style.fontSize! * textScaleFactor;
offsetY +=
font.emptyLineHeight * style.fontSize! * textScaleFactor;
}
top = 0;
bottom = 0;
Expand Down
Loading