chore: fix unchanged files with check annotations #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angular and react, plus another 'titleText' name in angular)
|
|
||
| const props = withDefaults( | ||
| defineProps<{ | ||
| icon: string, | ||
| tone?: 'warning' | 'info', | ||
| title? : string, | ||
| tone?: 'warning' | 'info', // eslint-disable-line vue/require-default-prop |
There was a problem hiding this comment.
may be better to add default value?
There was a problem hiding this comment.
I thought about this... The tone prop is optional in all frameworks, but gha / eslint check complains against vue only. There is code (again, for all frameworks) that checks against truthy value:
https://github.com/DevExpress/devextreme-ui-template-gallery/blob/master/packages/vue/src/components/library/ticker-card.vue#L53
Specifying a default value may affect the prop non specified behavior.
At the same time. adding smth like | undefined (see a prev commit), does not suppress a warn.
https://github.com/search?q=repo%3ADevExpress%2Fdevextreme-ui-template-gallery+%3Cticker-card+path%3A*.vue&type=code
What to choose then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.