Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix unchanged files with check annotations #390

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore: fix unchanged files with check annotations #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35430f2
'CardAnalytics' is defined but never used
mpreyskurantov Feb 28, 2025
cdd11dc
Prop 'title' requires default value to be set (non optional, like in …
mpreyskurantov Feb 28, 2025
b3bb58d
Unexpected console statement (github actions / aka eslint)
mpreyskurantov Feb 28, 2025
8a2d2b0
Prop 'tone' requires default value to be set
mpreyskurantov Mar 3, 2025
3fbe6fd
Prop 'tone' requires default value to be set (undefined -> eslint)
mpreyskurantov Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/shell/copy-themes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ copyFile(
join(__dirname, 'src', 'app', 'themes.json'),
(err) => {
if (err) throw err;
console.log('themes.json copied');
console.log('themes.json copied'); // eslint-disable-line no-console
},
);
5 changes: 2 additions & 3 deletions packages/vue/src/components/library/ticker-card.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,12 @@
import { formatPrice } from '@/utils/formatters';
import { Sales, SalesOrOpportunitiesByCategory } from '@/types/analytics';
import { computed, withDefaults } from 'vue';
import CardAnalytics from '@/components/library/card-analytics.vue';

const props = withDefaults(
defineProps<{
icon: string,
tone?: 'warning' | 'info',
title? : string,
tone?: 'warning' | 'info', // eslint-disable-line vue/require-default-prop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be better to add default value?

Copy link
Contributor Author

@mpreyskurantov mpreyskurantov Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this... The tone prop is optional in all frameworks, but gha / eslint check complains against vue only. There is code (again, for all frameworks) that checks against truthy value:
https://github.com/DevExpress/devextreme-ui-template-gallery/blob/master/packages/vue/src/components/library/ticker-card.vue#L53
Specifying a default value may affect the prop non specified behavior.
At the same time. adding smth like | undefined (see a prev commit), does not suppress a warn.
https://github.com/search?q=repo%3ADevExpress%2Fdevextreme-ui-template-gallery+%3Cticker-card+path%3A*.vue&type=code
What to choose then?

title: string,
data?: SalesOrOpportunitiesByCategory | Sales | null,
total?: string | null,
percentage: number,
Expand Down
Loading