Move Bower dependencies to npm

[DaniilSmirnov]

• Moved all bower dependencies to npm
• added running tests from package.json

[koral--]

Please add a sign-off, so DCO check will pass.

[DaniilSmirnov]

Sign-off added, checks passed :)

[koral--]

@denis99999 @pcrepieux WDYT?

[denis99999]

here are additional comments to the review:

• Why did you bring this PR, what is your motivation? Because even if bower is not recommended for a new front-end project, it works well and it is maintained, it is rather AngularJS which is no longer maintained and can be a problem for the evolution of the front-end .

• You should regenerate properly the yarn.lock file and commit it also, like this:

// first clean your repo (node_modules, etc.)
$ rm yarn.lock
$ npm install -g yarn
$ yarn install

• In local mode after the authentication step, the following warning appears in the web console, please fix it:
  

• while running yarn install, the following warning appears, please fix it:

debian@debian:~/GITHUB/stf$ . ../stf-build.sh 17.9.0
Now using node v17.9.0 (npm v8.5.5)
yarn install v1.22.18
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning "ng-file-upload > [email protected]" has unmet peer dependency "grunt@>=0.4.0".
[5/5] Building fresh packages...
success Saved lockfile.
$ not-in-install && gulp build || in-install
Done in 43.48s.

• while APK download using UI with an error message in a window the close button is no more present, I think this is due to your upgrade to AngularJS 1.5.11 from 1.5.0-rc2, here are the old behavior and the new one, please fix it:
  
  

[denis99999]

@denis99999 @pcrepieux WDYT?

Look at my review on this item! This line must not be removed and the errors generated must be solved!

[DaniilSmirnov]

• Why did you bring this PR, what is your motivation? Because even if bower is not recommended for a new front-end project, it works well and it is maintained, it is rather AngularJS which is no longer maintained and can be a problem for the evolution of the front-end .

I plan in the future (this or the next quarter of the year) to make a PR in which the angular will be replaced with something more modern, maybe React

[DaniilSmirnov]

Fixed in last commit

it happened after bootstrap update

[denis99999]

• trying to yarn install I got this error:

debian@debian:~/GITHUB/stf$ . ../stf-build.sh 17
Now using node v17.9.0 (npm v8.5.5)
yarn install v1.22.18
error An unexpected error occurred: "Unknown token: { line: 1458, col: 1, type: 'INVALID', value: undefined } 1458:1 in /home/debian/GITHUB/stf/yarn.lock".
info If you think this is a bug, please open a bug report with the information provided in "/home/debian/GITHUB/stf/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I removed yarn.lock file and regenerated it properly by running the yarn install command, do that please and do not update manuallly this file because that is forbidden and lead to inconsistencies

• After that yarn install and gulp test worked well, but trying to run STF locally I got the following exception, please fix it:

debian@debian:~/GITHUB/stf$ ./bin/stf local --public-ip 192.168.1.102
2022-04-21T09:41:41.376Z INF/util:procutil 9538 [*] Forking "/home/debian/GITHUB/stf/lib/cli migrate"
node:internal/validators:120
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:372:5)
    at validateString (node:internal/validators:120:11)
    at Object.parse (node:path:1450:5)
    at verify (/home/debian/GITHUB/stf/node_modules/please-update-dependencies/index.js:14:18)
    at module.exports (/home/debian/GITHUB/stf/node_modules/please-update-dependencies/index.js:131:8)
    at Object.<anonymous> (/home/debian/GITHUB/stf/lib/cli/please.js:2:38)
    at Module._compile (node:internal/modules/cjs/loader:1099:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/debian/GITHUB/stf/bin/stf:2:1)
    at Module._compile (node:internal/modules/cjs/loader:1099:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:975:32) {
  code: 'ERR_INVALID_ARG_TYPE'
}

• Before posting a commit on your PR, please fully test your updates, it is a prerequisite for a review whose main purpose is not to debug a PR, thanks

[denis99999]

At the risk of repeating myself, add 2 spaces to align the alias section

[denis99999]

can you make the change please

[denis99999]

I plan in the future (this or the next quarter of the year) to make a PR in which the angular will be replaced with something more modern, maybe React

What feature(s) do you plan to add to STF ?

[denis99999]

@DaniilSmirnov, look at PR #522 and PR DeviceFarmer/please-update-dependencies#1, they fix the remaining issue, when they will be merged, you will be able to restore the lib/cli/please.js file at his original state