Qual: Fix notices, update baseline, enable PhanTypeMismatchArgument #32901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeweerd
force-pushed
the
qual/phan.2025.1.31
branch
3 times, most recently
from
2b0feab to
d6c3622
Compare
|
Note: this PR will be split in 2 and is based on #32842 so will convert this as "Ready" when that is integrated. |
mdeweerd
force-pushed
the
qual/phan.2025.1.31
branch
4 times, most recently
from
4acd524 to
0c7d6b2
Compare
mdeweerd
force-pushed
the
qual/phan.2025.1.31
branch
from
0c7d6b2 to
952e033
Compare
# Qual: Fix phan notices Fix phan notices in fourn/commande (+form class)
# Qual: Fix phan notices Fix phan notices mostly in relation with supplier invoices, Fix phan notices in relation with formquestion (phpdoc update, casts).
# Qual: Update baseline, enable PhanTypeMismatchArgument Update the baseline for fixes. Enable PhanTypeMismatchArgument as this is being fixed and to avoid that new cases occur in files where these are fixed. Only about 3800 cases remain, was more than 12000 when starting with Phan.
mdeweerd
force-pushed
the
qual/phan.2025.1.31
branch
from
952e033 to
f750f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qual: Fix notices, update baseline, enable PhanTypeMismatchArgument
that new cases occur in files where these are fixed.
Only about 3800 cases remain, was more than 12000 when starting with Phan.