bff - Make user service methods async #1738
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erwinvandervalk
added
impact/breaking
Erwinvandervalk
force-pushed
the
bff-async-DefaultUserService
branch
from
f4165ed to
40c87cd
Compare
josephdecock
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DefaultUserService methods are now async.
Breaking change
If you have extended the DefaultUserService class and have overwritten either the .GetUserClaims() and/or .GetManagementClaims() method, you'll find now that these have now been replaced with async methods:
GetUserClaimAsync() and GetManagementClaimsAsync().
fixes #1702