-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tests failed to open catalog list #261
Conversation
730cbae
to
2d22655
Compare
I wanted to document what has been done as I am a bit stuck on what to try to fix the tests from here. What has been done so far:
|
For some reason the first click when selecting catalogs in the drawer selector fails. This leads to A LOT of tests failing as we use this function in pretty much all our tests. This temporary fix will let us test other functionality rather than just always failing. We really should completely rework how we naviagte to each document type in the future as this code is extemely fragile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be ideal but I am going to ahead and say that it's probably best to get our tests back to passing. We plan to do more significant work around document loading soon so I think this is fine.
Navigation Failing
For some reason the first click when selecting catalogs in the drawer selector fails. This leads to A LOT of tests failing as we use this function in pretty much all our tests.
This temporary fix will let us test other functionality rather than just always failing. We really should completely rework how we navigate to each document type in the future as this code is extremely fragile.
Loading Invalid Components Failing
When we intentionally put in invalid data, a
TypeError
is thrown. We are still able to reload new data after that failure, so we catch the exception. This test may be want to reconsidered when EasyDynamics/oscal-react-library#872 or subsequent related issues are completed.