Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests failed to open catalog list #261

Merged
merged 6 commits into from
May 26, 2023
Merged

fix: tests failed to open catalog list #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d22655
fix: Tests failed to open Catalog list
tuckerzp May 17, 2023
57f8f20
Test: revert to before react 18
tuckerzp May 19, 2023
dd1aaca
revert test
tuckerzp May 19, 2023
99d817c
fix: clicking twice causes test failure
tuckerzp May 25, 2023
70042c2
spelling
tuckerzp May 25, 2023
650ede6
Ignore TypeError when we intentionally throw it
tuckerzp May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions end-to-end-tests/cypress/e2e/OSCAL/OSCAL_Load_Tests.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,12 @@ describe("Errors caused by loading a bad component definition", () => {
});

it("do not persist after loading a valid component in Viewer", () => {
// Ignore TypeErrors for this test
cy.on(
"uncaught:exception",
(err) => !err.message.includes("Cannot read properties of undefined")
);

const sspExampleUrl =
"https://raw.githubusercontent.com/usnistgov/oscal-content/main/examples/ssp/json/ssp-example.json";
cy.navToCdefEditor(COMP_DEF_TITLE_ORIG);
Expand Down
21 changes: 17 additions & 4 deletions end-to-end-tests/cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,23 @@ Cypress.Commands.add("navToEditorByDrawer", (oscalType, pageTitle) => {
cy.wait(requestsMade, { timeout: 60000 });
}

cy.get('ul[aria-label="file system navigator"] li', { timeout: 30000 })
.should("have.attr", "aria-expanded", "false")
.contains(oscalType)
.click();
cy.get('ul[aria-label="file system navigator"] li', { timeout: 30000 }).should(
"have.attr",
"aria-expanded",
"false"
);

cy.contains(oscalType).trigger("click");

// TODO: For some reason the first click when selecting catalogs in the
// drawer selector fails. This leads to A LOT of tests failing as we use
// this function in pretty much all our tests.
// This temporary fix will let us test other functionality rather than just
// always failing. We really should completely rework how we navigate to each
// document type in the future as this code is extremely fragile.
if (oscalType === oscalObjectTypes[3].oscalType) {
cy.contains(oscalType).trigger("click");
}

cy.contains(pageTitle).click();
});
Expand Down