-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(el18): switch ADC channel and direction #3779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B & D switches are where they should be on EL18 (and also NV14), with all switches going the right way now.
This PR causes SWB & SWD to be swapped on the EL18 I received today. If I revert this PR then the two switches behave correctly. |
I think we really need to clarify what is the "normal" way...
This PR has 2 parts:
So once we clarified what is the "production" switch types & order, we'd need to recheck. |
With this PR, on my EL18 then the physical switch labelled SWB controls the SD switch in the firmware (Hardware, Inputs page). And physical switch SWD controls SB in the radio. SB is on the front of the radio top left, SD is front bottom right. If I revert the ADC_GPIO_PIN_SWx and ADC_CHANNEL_SWx changes then SB and SD work as labelled. Directions are all ok - I did not revert the ADC_DIRECTION change. |
And the default switch types are OK as well? @pfeerick we really need some feedback from FlySky.... |
The defaults in 2.10 are wrong for my EL18 if starting from scratch (new SD card).
Companion is the same with the additional issue that SC cannot be changed to 3POS. It can be changed to 3POS in the firmware; but not in companion (even if loading radio settings from the actual radio). |
Also the 2.10 firmware build on my EL18 lists T5 & T6 as trims. |
@philmoz we need to finish / integrate #3783, as this introduces the necessary bits to differentiate |
This probably need to be addressed separately, as this is no different from the NV14. |
Does that mean there are different EL18 switch configurations in production radios? |
So it seems. Mine is a pre-prod, so there is that. |
Back at #2675, the EL18 was changed from the switch configuration of the radios shipped to us from SWC toggle => 3 pos and we weren't informed of any other changes. This PR is correct for the NV14 and 2x EL18 that I have - one an early development sample, the other was supposed to be a production line sample (which Raphael should have one of as well), but then they went and changed those two switches. So the question then is - are ours wrong, or is yours? This isn't the first time that I've received a radio with the switches upside down, so we really need input from both Flysky AND more users. |
The manual I downloaded from the FlySky web site shows SC and SE as 2POS toggle switches; but it is dated 15th Nov 2022. |
Created #3860 to fix this. |
I've thrown the question to Flysky to answer, so hopefully we'll get some clarification on that soon. |
And now I'm really really confused :( When I powered the radio off and back on again SWB and SWD were swapped. Then when I went to the SYSTEM - HARDWARE page they got fixed back to their correct assignments????? This is not 100% reproducible - sometimes the switches are correct on power up. It also appears to be a time based thing that fixes them - if they are wrong on startup, waiting a seconds will fix it. |
Sorry for the question, but does all of this mean that we can select the NV14 if we have an EL18? I am just getting into the hobby again and got an EL18 last week. I'm loving it so far, but I'm confused by this thread. |
So why are you here reading this thread? Sucker for punishment? 🤣 But seriously, while around 2.7 and maybe even 2.8 you probably could have, I think now the EL18 firmware build is actually different to the NV14 firmware build. Even so, there is a Flysky EL18 firmware target in EdgeTX buddy, as well as two different firmware files since at least 2.9.x. |
Hyuuuuuuuup. ;)
I guess I was under the wrong impression that the companion could make setting up models a little easier at home in using the computer? So absolutely everything model related has to be done on the radio's touch screen? This is all making me feel extremely ignorant, so I apologize for it. |
Ah, now that is a different matter entirely... You didn't mention anything
about Companion before :-P The EL18 will become a first class citizen in
Companion in 2.10 - in other words you'll be able to use Companion with the
EL18 soon ;)
…On Thu, 26 Oct 2023, 2:48 am Robb Smith, ***@***.***> wrote:
So why are you here reading this thread? Sucker for punishment? 🤣
Hyuuuuuuuup. ;)
But seriously, while around 2.7 and maybe even 2.8 you probably could
have, I think now the EL18 firmware build is actually different to the NV14
firmware build. Even so, there is a Flysky EL18 firmware target in EdgeTX
buddy, as well as two different firmware files since at least 2.9.x.
I guess I was under the wrong impression that the companion could make
setting up models a little easier at home in using the computer? So
absolutely everything model related has to be done on the radio's touch
screen? This is all making me feel extremely ignorant, so I apologize for
it.
—
Reply to this email directly, view it on GitHub
<#3779 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KIXH6Y2OW7LAYWQFKDYBE7E5AVCNFSM6AAAAAA2CYPRCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGY3TIMJYGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That's great to hear, thank you VERY much for this information. I was
actually getting a smidge worried there for a second. I've already updated
the firmware to 2.9 so I'll patiently await 2.10. Thanks again!
Respectfully,
*-Robb Smith-*
*Electrical Engineer*
*EMAC Incorporated*
On Wed, Oct 25, 2023 at 4:00 PM Peter Feerick ***@***.***>
wrote:
… Ah, now that is a different matter entirely... You didn't mention anything
about Coloajion before :-P The EL18 will become a first class citizen in
Companion in 2.10 - in other words you'll be able to use Companion with
the
EL18 soon ;)
On Thu, 26 Oct 2023, 2:48 am Robb Smith, ***@***.***> wrote:
> So why are you here reading this thread? Sucker for punishment? 🤣
>
> Hyuuuuuuuup. ;)
>
> But seriously, while around 2.7 and maybe even 2.8 you probably could
> have, I think now the EL18 firmware build is actually different to the
NV14
> firmware build. Even so, there is a Flysky EL18 firmware target in
EdgeTX
> buddy, as well as two different firmware files since at least 2.9.x.
>
> I guess I was under the wrong impression that the companion could make
> setting up models a little easier at home in using the computer? So
> absolutely everything model related has to be done on the radio's touch
> screen? This is all making me feel extremely ignorant, so I apologize
for
> it.
>
> —
> Reply to this email directly, view it on GitHub
> <#3779 (comment)>,
or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABJ66KIXH6Y2OW7LAYWQFKDYBE7E5AVCNFSM6AAAAAA2CYPRCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGY3TIMJYGE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#3779 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKAPSNVDW2MPCHZ26NZERODYBF4WXAVCNFSM6AAAAAA2CYPRCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBQGA2DMNJYGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
No description provided.