Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bw): add 'Set Screen' special function to B&W radios #5589

Merged
merged 13 commits into from
Oct 17, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Oct 4, 2024

Fixes #3983

The parameter for the 'Set Screen' function can be from 0 to 4.

  • when set from 1 - 4 it will load the corresponding telemetry screen (if it is set up).
  • when set to 0 it will reload the normal main view.

Needs translation (must be kept short to fit on B&W screen):

#define TR_SF_SET_TELEMSCREEN          "Set Screen"

@philmoz philmoz added enhancement ✨ New feature or request B&W Related generally to black and white LCD radios needs:translation labels Oct 4, 2024
@philmoz philmoz added this to the 2.11 milestone Oct 4, 2024
@3djc
Copy link
Collaborator

3djc commented Oct 4, 2024

Repeat filed is enabled ?

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 4, 2024

Repeat filed is enabled ?

Yes, same as color implementation.

I assume this is so you can have !1x (not activated on startup).

@3djc
Copy link
Collaborator

3djc commented Oct 4, 2024

What does it do then ? Doesn't seem obvious to me

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 4, 2024

What does it do then ? Doesn't seem obvious to me

You mean the repeat field? It works the same as for any other SF/GF.

@3djc
Copy link
Collaborator

3djc commented Oct 4, 2024

So if you do "ON Set screen 1 1 enabled", you basicaly looked yourself out ?

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 4, 2024

So if you do "ON Set screen 1 1 enabled", you basicaly looked yourself out ?

Not locked out entirely - you would still have 1 second after pressing RTN to press MDL and fix it in the model setup.

It might be possible to limit the repeat to just !1x and 1x - will need to investigate.

@3djc
Copy link
Collaborator

3djc commented Oct 4, 2024

Tried on a TPro V2, RTN does get me out; but I have 1 sec to hit model in best case scenario (ie function just ran), even knowing the exact sequence I needed to do, it was almost impossible to unloock me out

@ajjjjjjjj
Copy link
Contributor

PL
#define TR_SF_SET_TELEMSCREEN "UstawEkran"

@ulfhedlund
Copy link
Contributor

SE
#define TR_SF_SET_TELEMSCREEN "Sätt skärm"

@pfeerick pfeerick changed the title feat(bw): add 'Set Screen' special function to B&W radios. feat(bw): add 'Set Screen' special function to B&W radios Oct 10, 2024
@pfeerick
Copy link
Member

pfeerick commented Oct 10, 2024

Can we get some translations for this please 😃 Will be merged in seven days or when translations complete, whichever comes first.

Please keep it short since it is only needed for B&W screens. Is a new SF that will allow you to trigger a telemetry screen to be shown. See initial comment for more details.

#define TR_SF_SET_TELEMSCREEN          "Set Screen"

The translation strings need to fit in this space:
screenshot_t20v2_24-10-10_16-54-14

@robustini
Copy link
Contributor

robustini commented Oct 10, 2024

IT
#define TR_SF_SET_TELEMSCREEN "Setta Schermo"

Too many characters for B&W? I hope not.

@froqstar
Copy link

froqstar commented Oct 10, 2024

DE
#define TR_SF_SET_TELEMSCREEN "TelSeite anz"

@philmoz
Copy link
Collaborator Author

philmoz commented Oct 10, 2024

DE #define TR_SF_SET_TELEMSCREEN "Tel.seite setzen"

This is too long - needs to fit in space shown in screenshot above.

@froqstar
Copy link

Fixed?

@Pat6874
Copy link
Contributor

Pat6874 commented Oct 10, 2024 via email

@3djc
Copy link
Collaborator

3djc commented Oct 10, 2024

FR: #define TR_SF_SET_TELEMSCREEN "Conf. écran" Le 10 oct. 2024, 03:55, à 03:55, Peter Feerick @.***> a écrit:

I"m sorry to disagree here, but "Conf. écran" is really misleading here; as there is no configuration involved. Maybe something like "Aff. écran" would be better suited

@ajjjjjjjj
Copy link
Contributor

PL updated
#define TR_SF_SET_TELEMSCREEN "Ustaw ekran"

@zandorsp
Copy link
Contributor

PT
#define TR_SF_SET_TELEMSCREEN "Def Tela"

@HThuren
Copy link
Contributor

HThuren commented Oct 10, 2024

DA
#define TR_SF_SET_TELEMSCREEN "Vis skærm"

@Eldenroot
Copy link
Contributor

CZ - is it fine for text lenght?

#define TR_SF_SET_TELEMSCREEN "Nast obrazovku"

@zyren
Copy link
Contributor

zyren commented Oct 13, 2024

CN


#define TR_SF_SET_TELEMSCREEN          "设置主屏"

TW


#define TR_SF_SET_TELEMSCREEN          "設置主屏"

@pfeerick pfeerick added the user manual change Will impact on the user manual in some respect label Oct 17, 2024
Per #5589 (comment)
as "Aff. écran" does appear to be more suitable translation.
@pfeerick
Copy link
Member

LGTM with RM Zorro

@pfeerick pfeerick merged commit e8224b8 into main Oct 17, 2024
51 checks passed
@pfeerick pfeerick deleted the philmoz/bw-set-screen-func branch October 17, 2024 05:58
pfeerick added a commit that referenced this pull request Oct 18, 2024
@Luznatural
Copy link

Luznatural commented Oct 18, 2024

Just in case you need a Spanish translation, as it's not listed above:

ES
#define TR_SF_SET_TELEMSCREEN "Ajuste pantalla"

@pfeerick
Copy link
Member

pfeerick commented Oct 18, 2024

Any chance of that being one letter shorter (as it runs right into the parameter atm)? And are you interested in translating future stuff for Spanish?

image

@Luznatural
Copy link

Yes to both questions:
ES
#define TR_SF_SET_TELEMSCREEN "Ajus. pantalla"

pfeerick added a commit that referenced this pull request Oct 18, 2024
pfeerick added a commit that referenced this pull request Oct 18, 2024
@ToshihiroMakuuchi
Copy link
Contributor

JP
#define TR_SF_SET_TELEMSCREEN "画面設定"

We are very sorry for the delay in confirmation.

@pfeerick
Copy link
Member

Better late than never! Much appreciated! :)

@kobakirill
Copy link
Contributor

Can we get some translations for this please 😃 Will be merged in seven days or when translations complete, whichever comes first.

Please keep it short since it is only needed for B&W screens. Is a new SF that will allow you to trigger a telemetry screen to be shown. See initial comment for more details.

#define TR_SF_SET_TELEMSCREEN          "Set Screen"

The translation strings need to fit in this space: screenshot_t20v2_24-10-10_16-54-14

#define TR_SF_SET_TELEMSCREEN "Устан экран"

@Luznatural
Copy link

Luznatural commented Oct 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios enhancement ✨ New feature or request needs:translation user manual change Will impact on the user manual in some respect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We dont have "Set Main Screen" function in black and white yet