Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor laser_callback method #89

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Refactor laser_callback method #89

merged 3 commits into from
Jan 27, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Jan 26, 2023

This is directly related to #57, but it should make #40 much easier to implement.

Summary

This patch is a small refactor of the laser_callback method in amcl_node.cpp. The functional changes are:

  • We now get different errors depending on which transform lookup failed.
  • We update the sensor and motion models with every laser scan message, if the robot has not moved we only skip the resampling step.
  • We publish a new estimate after every update of the filter.
  • Removes last_odom() method from the differential drive model interface.

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Jan 26, 2023
@nahueespinosa nahueespinosa self-assigned this Jan 26, 2023
@nahueespinosa
Copy link
Member Author

For now, pointing this to the nahuel/max_beams branch. Will redirect to main once #84 lands.

@nahueespinosa nahueespinosa added the ros Related to ROS label Jan 27, 2023
ivanpauno
ivanpauno previously approved these changes Jan 27, 2023
Copy link
Collaborator

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

beluga_amcl/src/amcl_node.cpp Show resolved Hide resolved
Signed-off-by: Nahuel Espinosa <[email protected]>
@nahueespinosa nahueespinosa changed the base branch from nahuel/max_beams to main January 27, 2023 15:54
@nahueespinosa nahueespinosa dismissed ivanpauno’s stale review January 27, 2023 15:54

The base branch was changed.

Signed-off-by: Nahuel Espinosa <[email protected]>
Signed-off-by: Nahuel Espinosa <[email protected]>
@nahueespinosa nahueespinosa merged commit 6a7c166 into main Jan 27, 2023
@nahueespinosa nahueespinosa deleted the nahuel/laser_callback branch January 27, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request ros Related to ROS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants