-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package to evaluate the impact of the beam skipping feature in nav2 #116
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Two thoughts.
- We can but we don't necessarily have to add another package for a different benchmark. We can accumulate benchmarks in a single package too.
- Tied to the above, eventually I would very much like to move Beluga benchmarks to Beluga. Putting all benchmarks in a single package will simplify that transition while keeping the Beluga repo sane. Either that or we have to start considering a separate Beluga benchmarks repository.
- Description | ||
* - `Willow Garage dataset <https://web.archive.org/web/20151207202459id_/http://cgi.cs.duke.edu/~mac/papers/iros12_sm.pdf>`_ | ||
- Large office environment with multiple recordings along different trajectories and times, including multiple rooms and hallways. | ||
* - `TorWIC SLAM dataset <https://github.com/Viky397/TorWICDataset>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glpuga do all these datasets apply here?
21ae1dd
to
1df7924
Compare
This is not necesarily intended to merge. It's just a quick and dirty benchmark draft to share with @DPR00 to get him up to speed with Ekumen-OS/beluga#187 , sparing him hitting the learning curve head on . We can later decide what we want to do with this. |
1df7924
to
54e0742
Compare
54e0742
to
816ba4b
Compare
Signed-off-by: Gerardo Puga <[email protected]>
7c1ef77
to
f657f40
Compare
…kipping feature in nav2
… beam skipping feature in nav2
… of the beam skipping feature in nav2
Proposed changes
Crude benchmark package to compare nav2-vs-nav2, likelihood vs likelihood_prob vs beam_skip.
This is part of a fact finding campaing for Ekumen-OS/beluga#187 .
Type of change
💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.Additional comments
Anything worth mentioning to the reviewers.