Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS-SDK 3.662 -> 3.687 #139821

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update AWS-SDK 3.662 -> 3.687 #139821

merged 1 commit into from
Nov 14, 2024

Conversation

ntsummers1
Copy link
Collaborator

@ntsummers1 ntsummers1 commented Nov 13, 2024

Description

That title ain't no liar

Related to #139814, #139815, and #139810


How to test

Run the app, load up a report, make some changes, see the save, load another, see its different, try printing, etc!


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

@ntsummers1 ntsummers1 self-assigned this Nov 13, 2024
@ntsummers1 ntsummers1 added the draft Just a draft label Nov 13, 2024
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5443 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Nov 13, 2024

Code Climate has analyzed commit 09244ee and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

@ntsummers1 ntsummers1 marked this pull request as ready for review November 13, 2024 18:48
@ntsummers1 ntsummers1 added ready for review Ready for all the reviews! and removed draft Just a draft labels Nov 13, 2024
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big ups! didn't see any degradation 🥇

@ntsummers1 ntsummers1 changed the base branch from main to update-ui-deps November 14, 2024 16:17
@ntsummers1 ntsummers1 merged commit 365e289 into update-ui-deps Nov 14, 2024
37 of 38 checks passed
@ntsummers1 ntsummers1 deleted the update-webservices branch November 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants