Fix updating parser when worklet hash doesn't change but closure does change #607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
@289Adam289 reported that
MarkdownTextInput
formatting does not reflect changes in parser worklet closure after a render. The reason is that currently we callregisterParser
only whenworkletHash
changes (ignoring the rules of React and ESLint warning).This PR changes the dependency array of
useMemo
so thatregisterParser
is called whenprops.parser
reference changes rather than onlyworkletHash
.It is the responsibility of library user to properly memoize the worklet parser
Related Issues
Requires #608.
Manual Tests
Linked PRs