Eliminate setText
call in applyNewStyles
on Android
#608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR refactors the implementation of
applyNewStyles
method on Android.Currently, in
applyNewStyles
we obtain the current value usinggetText
method and pass it tosetText
method in order to triggerMarkdownTextWatcher
. This works fine but can lead to infinite loop because callingsetText
(or evensetTextKeepState
) generates a selection update event. In live-markdown example app,onSelectionChange
callback always callssetSelection
(without comparingstart
andend
fields so it updates the reference toselection
state) which results in render that leads to anotherapplyNewStyles
call (not sure how exactly, though).Instead, we call
applyMarkdownFormatting
which doesn't emit selection change event.Related Issues
Required by #607.
Manual Tests
Linked PRs