Skip to content

Commit

Permalink
style: rename vastXml to vastXmlObj when dealing with parsed objects
Browse files Browse the repository at this point in the history
Signed-off-by: Fredrik Lundkvist <[email protected]>
  • Loading branch information
Lunkers committed Jan 24, 2025
1 parent 3e1f10b commit 8e53523
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/vast/vastApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,10 @@ const partitionCreatives = async (
};

const findMissingAndDispatchJobs = async (
vastXml: any,
vastXmlObj: any,

Check warning on line 164 in src/vast/vastApi.ts

View workflow job for this annotation

GitHub Actions / lint

Unexpected any. Specify a different type
opts: AdApiOptions
): Promise<ManifestResponse> => {
const creatives = await getCreatives(vastXml);
const creatives = await getCreatives(vastXmlObj);
const [found, missing] = await partitionCreatives(
creatives,
opts.lookUpAsset
Expand Down Expand Up @@ -220,8 +220,8 @@ const findMissingAndDispatchJobs = async (
};
});
const builder = new XMLBuilder({ format: true, ignoreAttributes: false });
const vastAsString = builder.build(vastXml);
return { assets: withBaseUrl, vastXml: vastAsString };
const vastXml = builder.build(vastXmlObj);
return { assets: withBaseUrl, vastXml: vastXml };
};

const getVastXml = async (
Expand Down

0 comments on commit 8e53523

Please sign in to comment.