Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to post VAST XML and replace creative URLs #12

Merged
merged 2 commits into from
Jan 24, 2025
Merged

feat: add option to post VAST XML and replace creative URLs #12

merged 2 commits into from
Jan 24, 2025

Conversation

Lunkers
Copy link
Collaborator

@Lunkers Lunkers commented Jan 24, 2025

No description provided.

@Lunkers Lunkers requested a review from birme January 24, 2025 10:31
@Lunkers Lunkers linked an issue Jan 24, 2025 that may be closed by this pull request
Possibility to submit a VAST XML #5
Closed
birme
birme requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just had a suggestion to change the use of vastXml variable to vastXmlObj when we are passing around a parsed XML

src/vast/vastApi.ts Outdated Show resolved Hide resolved
@Lunkers Lunkers requested a review from birme January 24, 2025 12:49
birme
birme approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good

@Lunkers Lunkers merged commit 0aeab75 into main Jan 24, 2025
4 checks passed
@Lunkers Lunkers deleted the 5-possibility-to-submit-a-vast-xml branch January 24, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birme birme birme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to submit a VAST XML
2 participants
@Lunkers @birme