Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: creatives without transcoded assets are not included in the VAST response #16

Merged
merged 1 commit into from
Jan 26, 2025
Merged

fix: creatives without transcoded assets are not included in the VAST response #16

merged 1 commit into from
Jan 26, 2025

Conversation

Lunkers
Copy link
Collaborator

@Lunkers Lunkers commented Jan 24, 2025

  • replace for-loop in replaceMediaFiles() with a reduce that only pushes creatives with transcoded assets.
  • remove an unused import

@Lunkers Lunkers requested a review from birme January 24, 2025 13:40
@Lunkers Lunkers linked an issue Jan 24, 2025 that may be closed by this pull request
Remove ads from VAST where M3U8 has not been created yet #13
Closed
birme
birme approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant solution!

@birme birme merged commit 4826cb1 into main Jan 26, 2025
4 checks passed
@birme birme deleted the 13-remove-ads-without-m3u8 branch January 26, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birme birme birme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ads from VAST where M3U8 has not been created yet
2 participants
@Lunkers @birme