Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osc context #2

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Osc context #2

merged 3 commits into from
Jan 22, 2025

Conversation

Lunkers
Copy link
Collaborator

@Lunkers Lunkers commented Jan 22, 2025

Refactor the config loading to automatically set up service access token for encore when submitting a job, instead of providing it as an environment variable that needs refreshing every so often.

Signed-off-by: Fredrik Lundkvist <[email protected]>
@Lunkers Lunkers requested a review from birme January 22, 2025 07:17
Signed-off-by: Fredrik Lundkvist <[email protected]>
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@Lunkers Lunkers merged commit 6ac2b92 into main Jan 22, 2025
4 checks passed
@Lunkers Lunkers deleted the osc-context branch January 22, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants