Fix float->int conversion overflow behaviour #4237
Conversation
bylaws
force-pushed
the
fpfix
branch
4 times, most recently
from
359d76d to
4539243
Compare
bylaws
changed the title
|
Does this handle underflow cases as well? |
|
This also fixes "The Talos Principle" timing bug with audio cutting out after a few seconds, and the intro scenes playing on superspeed. |
|
This also fixes #4217 |
|
This also fixes Animal Well's music have chirps and pops in it. |
bylaws
force-pushed
the
fpfix
branch
5 times, most recently
from
6df5706 to
7a32a1e
Compare
This is always used, removing it avoids needing to handle unused codepaths.
ARM behaviour here is to saturate on overflow or NaN inputs, whereas X86 returns a sentinel value of 2^(bitsize-1), explicitly emulate this.
bylaws
changed the title
This works with the standard arm behaviour, this is tested now |
|
Apparently this also fixes Satisfactory's dedicated server crashing. |
|
Good fix, and happy new year! For the record though, please avoid opening placeholder PRs without a description and changing them into proper ones after the fact. If people unsubscribe for what looks like a playground PR, these updates will be missed. (Depending on the mail client, all updates will be collapsed under the original PR title as well.) Opening a new PR instead avoids these problems. |
ARM behaviour here is to saturate on overflow or NaN inputs, whereas X86 returns a sentinel value of 2^(bitsize-1), explicitly emulate this.
Closes #2995