RangedAttackMob.attack -> RangedAttackMob.shootAt #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
added
refactor
apple502j
added
the
update-base
|
🚀 Target branch has been updated to 23w31a |
github-actions
bot
added
snapshot
liach
approved these changes
Aug 10, 2023
liach
added
the
update-base
|
🚀 Target branch has been updated to 23w32a |
github-actions
bot
removed
the
update-base
modmuss50
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RangedAttackMob.attack implies that the mob will attack themself.
RangedAttackMob.shootAt clearly states what is done, the mob shoots something (arrow, snowball or trident) at the Player, which may miss or hit something else.
I think shootAt is better suited in every case, but feel free to prove me wrong.