Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network related notes and changes #3624

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Conversation

liach
Copy link
Contributor

@liach liach commented Aug 9, 2023

play ping/pong -> common ping/pong
brand custom payload is both s2c and c2s
ConnectionIntent is only used by c2s handshake
Notes for ticking handlers and packet-based state transitions

@@ -13,6 +13,6 @@ CLASS net/minecraft/class_8610 net/minecraft/server/network/ServerConfigurationN
METHOD method_52407 (Lnet/minecraft/server/MinecraftServer$class_7460;)V
ARG 1 properties
METHOD method_52409 sendConfigurations ()V
METHOD method_52410 queueJoinWorldTask ()V
METHOD method_52410 endConfiguration ()V
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is correct, this method is only called from the unconfig debug command, and is not used during normal login/play. cancelConfiguration may be slightly better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't immediately end configuration indeed, but it prevents further tasks effectively. And its body is the same as the end of the sendConfiguration method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not wrong, and it is better than queueJoinWorldTask. Unless you have another idea im happy to go with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess will go with this and see mojang changes in snapshot

@liach liach added refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft labels Aug 9, 2023
@liach liach requested review from apple502j and a team August 9, 2023 15:05
@apple502j apple502j added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Aug 9, 2023
@github-actions github-actions bot changed the base branch from 23w31a to 23w32a August 9, 2023 15:32
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

🚀 Target branch has been updated to 23w32a

@github-actions github-actions bot removed the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Aug 9, 2023
@apple502j apple502j added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

🎉 Target branch is already set to 23w32a

@github-actions github-actions bot removed the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Aug 9, 2023
@modmuss50 modmuss50 merged commit 09474f2 into FabricMC:23w32a Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants