Network related notes and changes #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
reviewed
Aug 9, 2023
mappings/net/minecraft/server/network/ServerPlayNetworkHandler.mapping
Outdated
Show resolved
Hide resolved
modmuss50
reviewed
Aug 9, 2023
| @@ -13,6 +13,6 @@ CLASS net/minecraft/class_8610 net/minecraft/server/network/ServerConfigurationN | |||
| METHOD method_52407 (Lnet/minecraft/server/MinecraftServer$class_7460;)V | |||
| ARG 1 properties | |||
| METHOD method_52409 sendConfigurations ()V | |||
| METHOD method_52410 queueJoinWorldTask ()V | |||
| METHOD method_52410 endConfiguration ()V | |||
There was a problem hiding this comment.
I dont think this is correct, this method is only called from the unconfig debug command, and is not used during normal login/play. cancelConfiguration may be slightly better?
There was a problem hiding this comment.
This doesn't immediately end configuration indeed, but it prevents further tasks effectively. And its body is the same as the end of the sendConfiguration method.
There was a problem hiding this comment.
Its not wrong, and it is better than queueJoinWorldTask. Unless you have another idea im happy to go with this.
There was a problem hiding this comment.
Guess will go with this and see mojang changes in snapshot
….mapping Co-authored-by: apple502j <[email protected]>
liach
added
refactor
apple502j
added
the
update-base
|
🚀 Target branch has been updated to 23w32a |
github-actions
bot
removed
the
update-base
apple502j
approved these changes
Aug 9, 2023
apple502j
added
the
update-base
|
🎉 Target branch is already set to 23w32a |
github-actions
bot
removed
the
update-base
modmuss50
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
play ping/pong -> common ping/pong
brand custom payload is both s2c and c2s
ConnectionIntent is only used by c2s handshake
Notes for ticking handlers and packet-based state transitions