Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Disposal Pipes Ejection #220

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix Disposal Pipes Ejection #220

merged 1 commit into from
Oct 1, 2024

Conversation

Fansana
Copy link
Owner

@Fansana Fansana commented Oct 1, 2024

Description

This PR fixes an issue with disposal pipes that lead into space. The ejection would use the transform of the map instead of the one from the grid and throw into the wrong direction.
Another issue this fixes is with disposal bends which would take direction from a previous pipe instead of the current one.

Changelog

🆑

  • fix: Fix the disposal pipe ejection to space and after pipe bends.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files labels Oct 1, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title fix disposal pipes ejection Fix Disposal Pipes Ejection Oct 1, 2024
@Fansana
Copy link
Owner Author

Fansana commented Oct 1, 2024

This might also be a candidate for EE.

@Fansana Fansana merged commit 562b201 into master Oct 1, 2024
16 checks passed
Floof-Station-Bot added a commit that referenced this pull request Oct 1, 2024
Suraru added a commit to Suraru/Einstein-Engines that referenced this pull request Nov 11, 2024
Fix Disposal Pipes Ejection from Fansana

Fansana/floofstation1#220
Suraru added a commit to Suraru/deep-station-14 that referenced this pull request Nov 11, 2024
Fix Disposal Pipes Ejection from Fansana

Fansana/floofstation1#220
@Suraru
Copy link
Contributor

Suraru commented Nov 11, 2024

PR'd to upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants