Skip to content

Commit

Permalink
Merge pull request #543 from Financial-Times/drop-node-16
Browse files Browse the repository at this point in the history
Drop support for Node.js 16 and npm 7
  • Loading branch information
rowanmanning authored Jan 29, 2024
2 parents 3dd3bf5 + fb69e83 commit 40a5f66
Show file tree
Hide file tree
Showing 4 changed files with 60 additions and 70 deletions.
9 changes: 0 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ executors:
node18_19:
docker:
- image: cimg/node:18.19
node16_20:
docker:
- image: cimg/node:16.20
jobs:
checkout:
docker:
Expand Down Expand Up @@ -47,7 +44,6 @@ workflows:
executor:
- node
- node18_19
- node16_20
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand All @@ -60,7 +56,6 @@ workflows:
executor:
- node
- node18_19
- node16_20
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand All @@ -73,7 +68,6 @@ workflows:
executor:
- node
- node18_19
- node16_20
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand Down Expand Up @@ -108,7 +102,6 @@ workflows:
executor:
- node
- node18_19
- node16_20
- tool-kit/build:
name: tool-kit/build-<< matrix.executor >>
requires:
Expand All @@ -118,7 +111,6 @@ workflows:
executor:
- node
- node18_19
- node16_20
- tool-kit/test:
name: tool-kit/test-<< matrix.executor >>
requires:
Expand All @@ -128,4 +120,3 @@ workflows:
executor:
- node
- node18_19
- node16_20
1 change: 0 additions & 1 deletion .toolkitrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@ options:
nodeVersion:
- '20.11'
- '18.19'
- '16.20'
112 changes: 56 additions & 56 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
"version": "0.0.0",
"main": "index.js",
"dependencies": {
"@dotcom-reliability-kit/logger": "^2.4.2",
"@dotcom-reliability-kit/logger": "^3.0.3",
"lodash": "^4.17.21",
"metrics": "^0.1.8"
},
"devDependencies": {
"@dotcom-reliability-kit/eslint-config": "^2.0.1",
"@dotcom-reliability-kit/eslint-config": "^3.0.1",
"@dotcom-tool-kit/component": "^4.0.5",
"@dotcom-tool-kit/eslint": "^3.1.6",
"@dotcom-tool-kit/mocha": "^3.1.6",
Expand All @@ -29,8 +29,8 @@
"supertest": "^6.3.3"
},
"engines": {
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
"node": "18.x || 20.x",
"npm": "8.x || 9.x || 10.x"
},
"scripts": {
"prepare": "npx snyk protect || npx snyk protect -d || true",
Expand Down

0 comments on commit 40a5f66

Please sign in to comment.