chore: support RPC consistency mechanism #3741
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4 tasks
nedsalk
changed the title
nedsalk
commented
Feb 28, 2025
| @@ -2,4 +2,4 @@ | |||
| /// <reference types="next/image-types/global" /> | |||
|
|
|||
| // NOTE: This file should not be edited | |||
| // see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information. | |||
| // see https://nextjs.org/docs/app/api-reference/config/typescript for more information. | |||
There was a problem hiding this comment.
This got changed automatically.
nedsalk
commented
Feb 28, 2025
| @@ -224,6 +225,7 @@ export const launchNode = async ({ | |||
| ['--port', portToUse], | |||
| useInMemoryDb ? ['--db-type', 'in-memory'] : ['--db-path', tempDir], | |||
| ['--min-gas-price', minGasPrice], | |||
| ['--starting-gas-price', startingGasPrice], | |||
There was a problem hiding this comment.
Some tests against the latest master of fuel-core were failing until I added this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Merges into #3590 because that one contains the fixes to breaking changes between 0.40 and 0.41
Release notes
In this release, we:
required_fuel_block_heightto fix RPC consistency issuesSummary
flowchart TD Initialize[init: currentBlockHeight = 0] --> prepareRequest[prepare request] prepareRequest --> isRequestBlockSensitive[is request block height sensitive] isRequestBlockSensitive --> isSensitive[yes] isRequestBlockSensitive --> isNotSensitive[no] isSensitive --> addBlockHeight[inform required block height] addBlockHeight --> sendRequest[send request] isNotSensitive --> sendRequest[send request] sendRequest --> response[response has block height error?] response --> blockHeightError(yes) response --> noBlockHeightError(no) blockHeightError --> shouldRetry(should retry?) shouldRetry --> retry(yes) shouldRetry --> noRetry(no) retry --> wait(wait) wait --> sendRequest noRetry --> throwError(throw error) noBlockHeightError --> extractBlockHeight(extract block height from response) extractBlockHeight --> isHigher isHigher[is value higher than current?] isHigher --> higher[yes] isHigher --> nonHigher[no] higher --> updateBlockHeight[set new value] updateBlockHeight --> End[end] nonHigher --> EndChecklist