Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oshdb-filter] add additional geometry based filters #436

Merged
merged 32 commits into from
Nov 3, 2022

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Nov 25, 2021

Description

Adds the following new filters:

  • perimeter – select polygons based on the length of their boundary
  • geometry.vertices – selects geometries by their number of points (note: the end point of polygon rings count twice)
  • geometry.inners/geometry.outers – selects (multi)polygons by their number of parts (outer or inner rings)
  • geometry.roundness – selects polygons by their compactness value (using the Polsby-Popper test score)
  • geometry.squareness – selects geometries by their squareness value (see paper for the definition)

Corresponding issue

See #311

todo

  • add to documentation
  • add to changelog

Checklist

@tyrasd tyrasd added the enhancement New feature or request label Nov 25, 2021
@tyrasd tyrasd self-assigned this Nov 25, 2021
@tyrasd tyrasd linked an issue Nov 25, 2021 that may be closed by this pull request
14 tasks
@tyrasd tyrasd changed the title 🚧 [oshdb-filter] add additional geometry based filters [oshdb-filter] add additional geometry based filters Oct 20, 2022
@tyrasd tyrasd force-pushed the filter-geometries branch from 6e32c21 to 86c1b5a Compare October 20, 2022 16:07
@tyrasd
Copy link
Member Author

tyrasd commented Oct 20, 2022

this is now ready to be reviewed 😊

@tyrasd tyrasd requested a review from rtroilo October 20, 2022 17:33
@Hagellach37 Hagellach37 added this to the release 1.0 milestone Oct 20, 2022
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good test coverage. Thanks for the PR!

General remark: Tests could be organized to ensure more fine-grained test titles (e.g. use existing comments about geometry types and spilt tests there). @DisplayName could be used to set an explizit descriptive name for the test. For more hirarchy, @Nested could be used. Examples see: https://blogs.oracle.com/javamagazine/post/beyond-the-simple-an-in-depth-look-at-junit-5s-nested-tests-dynamic-tests-parameterized-tests-and-extensions

oshdb-filter/README.md Outdated Show resolved Hide resolved
oshdb-filter/README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
oshdb-filter/README.md Outdated Show resolved Hide resolved
oshdb-filter/README.md Outdated Show resolved Hide resolved
@tyrasd tyrasd force-pushed the filter-geometries branch from 18e5251 to d168a20 Compare November 2, 2022 17:36
@tyrasd tyrasd requested a review from joker234 November 3, 2022 12:29
Co-authored-by: Johannes Visintini <[email protected]>
@tyrasd tyrasd requested a review from joker234 November 3, 2022 15:44
@tyrasd tyrasd merged commit abe3c9e into master Nov 3, 2022
@tyrasd tyrasd deleted the filter-geometries branch November 3, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants