-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oshdb-filter] add additional geometry based filters #436
Conversation
54c7451
to
aaccc30
Compare
6e32c21
to
86c1b5a
Compare
this is now ready to be reviewed 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very good test coverage. Thanks for the PR!
General remark: Tests could be organized to ensure more fine-grained test titles (e.g. use existing comments about geometry types and spilt tests there). @DisplayName
could be used to set an explizit descriptive name for the test. For more hirarchy, @Nested
could be used. Examples see: https://blogs.oracle.com/javamagazine/post/beyond-the-simple-an-in-depth-look-at-junit-5s-nested-tests-dynamic-tests-parameterized-tests-and-extensions
oshdb-filter/src/main/java/org/heigit/ohsome/oshdb/filter/FilterParser.java
Show resolved
Hide resolved
oshdb-filter/src/main/java/org/heigit/ohsome/oshdb/filter/FilterParser.java
Show resolved
Hide resolved
oshdb-filter/src/main/java/org/heigit/ohsome/oshdb/filter/FilterParser.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/test/java/org/heigit/ohsome/oshdb/util/geometry/GeoTest.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/test/java/org/heigit/ohsome/oshdb/util/geometry/GeoTest.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/test/java/org/heigit/ohsome/oshdb/util/geometry/GeoTest.java
Outdated
Show resolved
Hide resolved
oshdb-util/src/test/java/org/heigit/ohsome/oshdb/util/geometry/GeoTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Johannes Visintini <[email protected]>
18e5251
to
d168a20
Compare
oshdb-filter/src/test/java/org/heigit/ohsome/oshdb/filter/ApplyOSMGeometryTest.java
Outdated
Show resolved
Hide resolved
oshdb-filter/src/test/java/org/heigit/ohsome/oshdb/filter/ApplyOSMGeometryTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Johannes Visintini <[email protected]>
Description
Adds the following new filters:
perimeter
– select polygons based on the length of their boundarygeometry.vertices
– selects geometries by their number of points (note: the end point of polygon rings count twice)geometry.inners
/geometry.outers
– selects (multi)polygons by their number of parts (outer or inner rings)geometry.roundness
– selects polygons by their compactness value (using the Polsby-Popper test score)geometry.squareness
– selects geometries by their squareness value (see paper for the definition)Corresponding issue
See #311
todo
Checklist
I have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository