feat: inventory check inspects large fluid containers #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds the necessary code to check large fluid cells for their liquid content. In these cases, it now generates an instance of
LFluidStack
instead ofLItemStack
. This does mean that recipes requiring large fluid stacks filled with a liquid might mis-behave, but I could not find any such recipes. A potential fix to this is to return aCollection<ILabel>
instead of a singleILabel
from theILabel.Converter#from
method.I tried that, but I wasn't too sure about the implications on other code parts, so I left it out (there were three places that required changes).
There are also other fluid containers (I think they are from Forestry?) in GTNH, but those are used as normal item ingredients in recipes. Therefore, I didn't add them in this PR. I am also not sure if they can be used to fill machines with their contents.
Fixes #10.