Fixed stacks of more than one fluid cell. (#29, #30) #31
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29, fixes #30.
It's not clear to me whether the fix belongs in here or in
GTUtility. It works, I just don't know if theGTUtilitycode is wrong and other (undiscovered?) bugs would be fixed by changing it instead. Also, if later on a multiplication is added to theGTUtilitycode, then we'll end up with a "double multiply" bug.btw, I couldn't get
./gradlew runClientto work without addingcompile("com.github.GTNewHorizons:GT5-Unofficial:5.09.51.33:dev")tobuild.gradle. (it crashes withNoClassDefErroronGTUtilitywithout the addition). I'm not familiar with the intricacies of class loading in modded minecraft, but I assume it's omitted for a reason, so I left it out here.