-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the kedro pandera infer
CLI, add log where the file is written to
#9
Improve the kedro pandera infer
CLI, add log where the file is written to
#9
Conversation
…ten to Signed-off-by: Nok Chan <[email protected]>
docs/Makefile
Outdated
@@ -18,3 +18,6 @@ help: | |||
# "make mode" option. $(O) is meant as a shortcut for $(SPHINXOPTS). | |||
%: Makefile | |||
@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) | |||
|
|||
lint: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the expected benefit here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this is in the root directory, will remove this from here.
I think having a Makefile
is beneficial to organise some scripts a bit. It can be re-used later in CI or setup local environment
I expect these will exist eventually make install-test-requirements.txt
, make test
,make lint
etc.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 51 52 +1
=========================================
+ Hits 51 52 +1
☔ View full report in Codecov by Sentry. |
|
||
test: | ||
pytest | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it for now, I'll create a separate PR to create all these command in the appropriate directory.
Description
Why was this PR created?
Development notes
What have you changed, and how has this been tested?
Makefile
for lintChecklist
CHANGELOG.md
file. Please respect Keep a Changelog guidelines.Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.